Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 BalanceInput height #6899

Merged
merged 2 commits into from
Aug 23, 2023
Merged

🔧 BalanceInput height #6899

merged 2 commits into from
Aug 23, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Aug 23, 2023 •
edited
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
    image

Copilot Summary

🤖 Generated by Copilot at bb0ef29

Improved the UI of the balance input component by adding a custom CSS class. This affects the file components/shared/BalanceInput.vue.

🤖 Generated by Copilot at bb0ef29

To make the balance input look nice
We added a custom CSS class
It's called .h-full
And it makes the element tall
So it fills the parent's height with sass

@daiagi daiagi requested a review from a team as a code owner August 23, 2023 07:42
@daiagi daiagi requested review from roiLeo and Jarsen136 and removed request for a team August 23, 2023 07:42
@kodabot
Copy link
Collaborator

kodabot commented Aug 23, 2023

SUCCESS @daiagi PR for issue #6871 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 23, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4cbc530
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e5d6cf3a6d7e000854a4d0
😎 Deploy Preview https://deploy-preview-6899--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 23, 2023

AI-Generated Summary: This pull request introduces changes to the styling of BalanceInput component in Vue.js. A new CSS class 'h-full' is added to increase the height of the elements to 100%. This styling is applied to the NeoSelect element within the BalanceInput, presumably to improve UI alignment or to fill the available space more effectively. Please review the visual effects of these changes to ensure they align with the desired design outcomes.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 23, 2023
@daiagi
Copy link
Contributor Author

daiagi commented Aug 23, 2023

forms affected:

image

@roiLeo roiLeo requested a review from prury August 23, 2023 07:47
@codeclimate
Copy link

codeclimate bot commented Aug 23, 2023

Code Climate has analyzed commit 4cbc530 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

roiLeo
roiLeo approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noice!
Screenshot 2023-08-23 at 12-05-15 KodaDot Low fees and low carbon minting KodaDot - NFT Market Explorer

@yangwao
Copy link
Member

yangwao commented Aug 23, 2023 •
edited
Loading

great! Hope Simple Mint will be out soon

@yangwao yangwao merged commit 4b2f708 into main Aug 23, 2023
11 checks passed
@yangwao yangwao deleted the fix/BalanceInput-height branch August 23, 2023 10:53
This was referenced Aug 23, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@prury prury Awaiting requested review from prury

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The KSM button style should be consistent with the rest of the form.
5 participants
@daiagi @kodabot @yangwao @roiLeo @Jarsen136