Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 close wallet modal when click set identity #6901

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Aug 23, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at c11a879

Improved security and usability of WalletAssetSetIdentity component by using custom events and plain links.

🤖 Generated by Copilot at c11a879

To close the modal with a click
We replaced <nuxt-link> with <a>
And added some events to the mix
To handle the custom logic
This makes the component more secure and slick

@daiagi daiagi requested a review from a team as a code owner August 23, 2023 08:13
@daiagi daiagi requested review from roiLeo and Jarsen136 and removed request for a team August 23, 2023 08:13
@kodabot
Copy link
Collaborator

kodabot commented Aug 23, 2023

WARNING @daiagi PR for issue #6721 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #6721

@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4a49480
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e5d4dbd936c80008fb0cf2
😎 Deploy Preview https://deploy-preview-6901--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 23, 2023

AI-Generated Summary: This pull request closes the wallet modal upon setting the identity. It modifies the "WalletAssetSetIdentity.vue" component, replacing an existing <nuxt-link> with a safer <a> tag for linking to the onchain identity creation page. Additionally, it adds a new function called closeModal which logs the close action and triggers an emit event for 'close'. Finally, the usage of "remember-identity" is still preserved in the local storage. Overall, these changes improve both the safety and user experience of the wallet modal feature.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 23, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove console log
  • use @click.native if you want to handle click
  • keep nuxt-link

components/common/ConnectWallet/WalletAssetSetIdentity.vue Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Aug 23, 2023

Code Climate has analyzed commit 4a49480 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@Jarsen136 Jarsen136 added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels Aug 23, 2023
@yangwao yangwao merged commit 201d55a into main Aug 23, 2023
11 checks passed
@yangwao yangwao deleted the fix/wallet-modal-close-set-idenitity branch August 23, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sidebar modal won't close after clicking on Create your on Chain ID
5 participants