Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: dead bird to X #6919

Merged
merged 1 commit into from
Aug 24, 2023
Merged

style: dead bird to X #6919

merged 1 commit into from
Aug 24, 2023

Conversation

stephenjason89
Copy link
Contributor

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

Footer and all the other locations uses that X
image

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 769abca

Refactored the code for opening the shopping cart modal from the navbar. Moved the logic and configuration from ShoppingCartModalConfig.ts and ShoppingCartButton.vue to Navbar.vue to improve code organization and performance.

🤖 Generated by Copilot at 769abca

ShoppingCartButton
Simpler, no more emit -
Autumn leaves falling

@stephenjason89 stephenjason89 requested a review from a team as a code owner August 23, 2023 14:34
@stephenjason89 stephenjason89 requested review from preschian and roiLeo and removed request for a team August 23, 2023 14:34
@kodabot
Copy link
Collaborator

kodabot commented Aug 23, 2023

SUCCESS @stephenjason89 PR for issue #6851 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4621261
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64e61904d4e1830008ef28e0
😎 Deploy Preview https://deploy-preview-6919--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codeclimate
Copy link

codeclimate bot commented Aug 23, 2023

Code Climate has analyzed commit 4621261 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 23, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stephenjason89
Copy link
Contributor Author

stephenjason89 commented Aug 23, 2023

@yangwao The Twitter bird didn't just fly away; X marks its final resting spot. 🐦✖️

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 23, 2023
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Aug 24, 2023
@yangwao
Copy link
Member

yangwao commented Aug 24, 2023

pay 30 usd

@yangwao yangwao merged commit 1fb6b4f into kodadot:main Aug 24, 2023
11 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 24, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.48 USD/DOT ~ 6.696 $DOT
🧗 16UcV9V6nVvPYdHz98ymUKmNLkzjCEU5sbKJMi7hxYyTHjzR
🔗 0x577e8b29080d74c5e35980ddae54c135bf64610a18847ad47fc8a9f2c29b9792

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 24, 2023
This was referenced Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace dead bird in footer - Bird is ded, X is new vigilant
6 participants