Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add github cli instruction to first-time.md #6978

Merged
merged 3 commits into from
Aug 28, 2023

Conversation

thnaylor
Copy link
Contributor

@thnaylor thnaylor commented Aug 26, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at e6a1481

Added a new section on how to use GitHub CLI to create pull requests to first-time.md blog post. This change helps first-time contributors follow the project's contribution guidelines and templates.

🤖 Generated by Copilot at e6a1481

first-time.md changed
Learn to use GitHub CLI
Autumn of coding

@netlify
Copy link

netlify bot commented Aug 26, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5c3a630
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ea61f1bb00f20008b9b842
😎 Deploy Preview https://deploy-preview-6978--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Aug 26, 2023

SUCCESS @thnaylor PR for issue #6967 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 26, 2023

AI-Generated Summary: This pull request introduces additional instructions in the 'first-time.md' blog file. Specifically, it adds guidelines on how to submit a pull request using the GitHub CLI. It provides step-by-step instructions from ensuring authentication to using predefined templates for pull requests. Additionally, the update gives an option for users who cannot use GitHub CLI, showing them where to find the templates and how to create a pull request directly on GitHub.

@reviewpad reviewpad bot added small Pull request is small docs labels Aug 26, 2023
@thnaylor thnaylor marked this pull request as ready for review August 26, 2023 20:25
@thnaylor thnaylor requested a review from a team as a code owner August 26, 2023 20:25
@thnaylor thnaylor requested review from stephenjason89 and roiLeo and removed request for a team August 26, 2023 20:25
@codeclimate
Copy link

codeclimate bot commented Aug 26, 2023

Code Climate has analyzed commit 5c3a630 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stephenjason89 stephenjason89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍 I like github cli 🤩

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 28, 2023
@prury
Copy link
Member

prury commented Aug 28, 2023

wait, mobile has a small problem:
image
maybe use formatting similar to the other parts of the article to avoid it?

@vikiival
Copy link
Member

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Aug 28, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.5 USD/DOT ~ 4.444 $DOT
🧗 123PCJXhjb15i6JwVVRGd7KvN2sSNZrtPjr5doJq9oWctoTt
🔗 0xf1a1084823b2c12eae3a2ce6e80012a19a91d19309f9d4b95fe9cd4a624b6a67

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 28, 2023
@thnaylor
Copy link
Contributor Author

@prury It would be better to make this into another ticket because we already use lists on other blogs which have the same issue. So may be best to fix the problem globally.

Also the list font is inconsistent on desktop as well so could also be something to add.

@prury prury mentioned this pull request Aug 28, 2023
@vikiival vikiival added this pull request to the merge queue Aug 28, 2023
Merged via the queue into kodadot:main with commit 1272e1f Aug 28, 2023
15 checks passed
@yangwao yangwao mentioned this pull request Aug 30, 2023
@yangwao yangwao mentioned this pull request Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mention for first time blog post to use GH CLI
7 participants