Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Explore quick links followup #7010

Merged
merged 1 commit into from
Aug 28, 2023
Merged

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Aug 28, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at 9b6e3d0

Improved the navbar explore options by adding more spacing, disabling unused features, and showing chain names with labels. Added new classes to global and main navigation styles to support the labels. Modified components/navbar/NavbarExploreOptions.vue, styles/global.scss, and styles/layouts/_main-navigation.scss.

🤖 Generated by Copilot at 9b6e3d0

We are the rebels of the web, we defy the status quo
We explore the chains of doom, with the beta labels on
We align the signs of fate, with the k-shade of our soul
We close the gates of hell, when the mobile nav is gone

@Jarsen136 Jarsen136 requested a review from a team as a code owner August 28, 2023 14:09
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team August 28, 2023 14:09
@kodabot
Copy link
Collaborator

kodabot commented Aug 28, 2023

SUCCESS @Jarsen136 PR for issue #7003 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 9b6e3d0
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ecaa7e4be9610008482c32
😎 Deploy Preview https://deploy-preview-7010--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codeclimate
Copy link

codeclimate bot commented Aug 28, 2023

Code Climate has analyzed commit 9b6e3d0 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136 Jarsen136 requested a review from prury August 28, 2023 14:09
@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 28, 2023

AI-Generated Summary: This pull request includes updates to the NavbarExploreOptions.vue component, as well as global.scss and _main-navigation.scss style sheets.

In NavbarExploreOptions.vue, spacing was increased between the menu items, a color class was added to the 'users' menu item, and the "soon" text was reformatted. The elements that list the user's chain options were also substantially reworked. They now include a conditional display of a 'beta' label and fetch their content differently, no longer using the getChainNameByPrefix function, but rather a newly-defined mapping object.

The global.scss update added a new color styling rule.

In _main-navigation.scss, the style for aligning text was changed from aligning to the bottom to aligning to the top. These updates combine user interface improvements with some refactoring for cleaner, more maintainable code.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Aug 28, 2023
@exezbcz
Copy link
Member

exezbcz commented Aug 28, 2023

@prury mobile bug master 👀 letsgo, works for me

@yangwao yangwao merged commit 40ef807 into kodadot:main Aug 28, 2023
16 checks passed
This was referenced Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explore quick links followup
5 participants