refactor: mergeCollection & mergeNFT

[stephenjason89]

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

@/components/rmrk/service/scheme has 2 functions which are synonymous but have different types.
This PR aims to combine those 2 functions into 1.

Since it wasn't used anywhere, I didn't had to change references to the old functions.

• Bugfix
• Feature
• Refactoring

Context

• Related to Mitigate Technical debt - bonus round  #6782
• Requires deployment <snek/rubick/worker>

Before submitting pull request, please make sure:

• My contribution builds clean without any errors or warnings
• I've merged recent default branch -- main and I've no conflicts
• I've tried to respect high code quality standards
• I've didn't break any original functionality

Optional

• I've tested it at </ksm/collection>
• I've tested PR on mobile
• I've written unit tests 🧪
• I've found edge cases

Did your issue had any of the "$" label on it?

• Fill up your DOT address: Payout

Community participation

• Are you at KodaDot Ecosystem Telegram?

Screenshot 📸

• My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 7997e50

Refactored mergeCollection and mergeNFT into a single generic function mergeNFTCollection in scheme.ts. This simplifies the code and ensures consistent merging of NFT and collection data with metadata.

🤖 Generated by Copilot at 7997e50

mergeNFTCollection
One function for both types
Simpler and safer

[netlify]

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	755394e
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/64ee3b9cc51bf4000874d069
😎 Deploy Preview	https://deploy-preview-7011--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[reviewpad]

AI-Generated Summary: This pull request contains a code refactoring in the scheme.ts file within the RMRK service. The changes specifically focus on merging the separate mergeCollection and mergeNFT functions into a single, reusable, and more general function named mergeNFTCollection. A type alias MergedData<T> is also introduced which makes use of TypeScript's conditional types. This allows for a clean, generic function that works for both Collection and NFT types, improving the maintainability of the code.

[codeclimate]

Code Climate has analyzed commit 7997e50 and detected 0 issues on this pull request.

View more on Code Climate.

[reviewpad]

Reviewpad Report

⚠️ Warnings

• Please link an issue to the pull request

[yangwao]

pay 30 usd

[yangwao]

pay 30 usd

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.7 USD/DOT ~ 6.383 $DOT
🧗 13rFRPVKjJzQXVC8ZqHZv5YMmwmk4MU7z4HeYk218hEMpQXH
🔗 0x5562ba07fedf2c6f6737487ba146eaeba781f58229117348f6af97fbc1e5c575

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.7 USD/DOT ~ 6.383 $DOT
🧗 13rFRPVKjJzQXVC8ZqHZv5YMmwmk4MU7z4HeYk218hEMpQXH
🔗 0x8105e340a9ef12a725c5792ae572f7c518eff686f5a59ae923c17c53ced5f054

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.6% Duplication

[yangwao]

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.69 USD/DOT ~ 6.397 $DOT
🧗 13rFRPVKjJzQXVC8ZqHZv5YMmwmk4MU7z4HeYk218hEMpQXH
🔗 0x7ba545afaa5fb719642b0d3a980000fd1be447ad259dc3d462f9f266d5dcb016

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

[yangwao]

impressive, bot hijack 😅
seems Github Webhooks <> Autocode Gateway has some delayed dispatch

• Fix failed payments on pull-requests #7035