fix multi recipient royalties on Details Tab #7013
Conversation
niklasp
requested review from
preschian and
roiLeo
and removed request for
a team
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
AI-Generated Summary: This pull request contains changes that fix issue #6970. The modifications are made to the 'GalleryItemDescription.vue' file. Changes include adding a condition to check if the 'recipient' is an array and handling this scenario accordingly in the UI. The displayed 'recipient' now can handle single or multiple recipients (displayed as a list), specified with their address and percentage share. Additionally, error handling has been added to catch any exception caused by JSON parsing the 'recipient' data. Additional styles have also been added to adjust the look of the recipient section, which includes flex-direction, alignment of items, text transformation, and color among others. |
|
@niklasp please fix your PR with a PR template. Thanks Converted to draft till then. |
|
Code Climate has analyzed commit 71d70fb and detected 0 issues on this pull request. View more on Code Climate. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@prury @preschian ready for review |
|
pay 50 usd |
|
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
cool, before that we have to add fields on the NFT creation page to add more than one royalty recipient and percentages |
prury
added
the
S-works-for-me-✅
|
thanks for the assistance |
PR Type
Context
Did your issue had any of the "$" label on it?
Copilot Summary
🤖 Generated by Copilot at 7483263
Display and style NFT transfer recipients in
GalleryItemDescription.vue. Use a computed property to format the data and a template to render it.🤖 Generated by Copilot at 7483263
Description
backward compatible version of multiroyalties according to the design guide given
http://localhost:9090/ahk/gallery/101-3962765076 => multi royalty) in array format [[addr0, perc0], [addr1, perc1], ...]
http://localhost:9090/ahk/gallery/101-3163187696 => single royalty in array format [[addr0,perc0]]
http://localhost:9090/ksm/gallery/19381324-BC4ECCF7AB22138D66-SMS-SOL_SMS_22_KSM-00000001 (old royalty, just address)