Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adjust profile bottom nav #7017

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Conversation

thnaylor
Copy link
Contributor

@thnaylor thnaylor commented Aug 28, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at c6744e0

Improved the UI and UX of the wallet asset menu component. Used nuxt-link for settings to optimize performance.

🤖 Generated by Copilot at c6744e0

Oh we're the crew of the nuxt-link ship, and we sail the web so fast
We tweak the icons and align the elements, to make the wallet asset menu last
Heave away, me hearties, heave away with glee
We'll raise the yardarm with our code, on the count of one, two, three

@kodabot
Copy link
Collaborator

kodabot commented Aug 28, 2023

SUCCESS @thnaylor PR for issue #7015 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 28, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c6744e0
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ed05e699d29c0008b451c1
😎 Deploy Preview https://deploy-preview-7017--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 28, 2023

AI-Generated Summary: This pull request involves a refactor in the WalletAssetMenu.vue component in the ConnectWallet directory. The refactor comprises formatting changes, a change from direct hyperlink tag to Nuxt.js syntax for a single route to settings, and several icon size and positioning adjustments to enhance the user interface. The refactor impacts how the wallet asset menu, color mode toggle, language component and settings link are displayed. Overall, this is to improve the readability and layout of the profile sidebar.

@reviewpad reviewpad bot added the small Pull request is small label Aug 28, 2023
@codeclimate
Copy link

codeclimate bot commented Aug 28, 2023

Code Climate has analyzed commit c6744e0 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Aug 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@thnaylor
Copy link
Contributor Author

Hi @exezbcz

Just want to clear some things before submitting...

  1. Did you want to increase the padding above & below the buttons to 24px?
    image

  2. The closest natural size on font awesome is 24px (fa-2x) which is the same as the Figma design. is that okay?
    image

@exezbcz
Copy link
Member

exezbcz commented Aug 29, 2023

@thnaylor good, thanks!

@yangwao yangwao marked this pull request as ready for review August 29, 2023 10:58
@yangwao yangwao requested a review from a team as a code owner August 29, 2023 10:58
@yangwao yangwao requested review from stephenjason89 and Jarsen136 and removed request for a team August 29, 2023 10:58
@yangwao
Copy link
Member

yangwao commented Aug 29, 2023

pay 30 usd

@yangwao yangwao merged commit 4d09fcb into kodadot:main Aug 29, 2023
16 checks passed
@yangwao
Copy link
Member

yangwao commented Aug 29, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.54 USD/DOT ~ 6.608 $DOT
🧗 123PCJXhjb15i6JwVVRGd7KvN2sSNZrtPjr5doJq9oWctoTt
🔗 0xedccfacee5e04cca6e5ccd1a476b6a09300289abebd407ba2a3031ff6d70a058

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 29, 2023
@yangwao yangwao removed the paid pull-request has been paid label Aug 30, 2023
@yangwao
Copy link
Member

yangwao commented Aug 30, 2023

pay 30 usd

@yangwao
Copy link
Member

yangwao commented Aug 30, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.59 USD/DOT ~ 6.536 $DOT
🧗 123PCJXhjb15i6JwVVRGd7KvN2sSNZrtPjr5doJq9oWctoTt
🔗 0xfcfab801b6e91842e553f59fb40d5184352b826db281d970e929b2113a196a04

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 30, 2023
This was referenced Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Margin on profile sidebar bottom buttons
4 participants