Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/h1 #7040

Merged
merged 7 commits into from
Aug 30, 2023
Merged

Chore/h1 #7040

merged 7 commits into from
Aug 30, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Aug 30, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • SEO

Context

Did your issue had any of the "$" label on it?

Yes $

Summary

URL Existing Tag Changed?
/series-insight h1 No
/cookie-notice h2 Yes
/prefix/explore/items h1 No
/prefix/explore/collectibles h1 No
/prefix/claim p Yes
/hot h1 No
/prefix/incomingOffers h1 No
/error p Yes
/prefix/assets h1 No
/ h1 No
/prefix/stats h1 No
/rmrk/mint h1 No
/prefix/waifu h1 Yes
/qrCode None Not applicable
/e2e-login None Not applicable
/prefix/offers None Not applicable
/prefix/massmint None Not applicable
/settings None Not applicable
/carbonless h1 No
/sustainability h1 No
/spotlight h1 No
/sales h1 No
/identity p Yes
/prefix/drops div Yes
/prefix/teleport p Yes

/prefix/create - collection tab
skipped on account of

@yangwao the image you posted in the issue is largly inaccurate, many of the pages did have a proper h1 already

Copilot Summary

🤖 Generated by Copilot at 04ef6a6

This pull request enhances the accessibility and readability of various components and pages by using proper heading tags for titles and tooltips. It also refactors some code to use a utility function for formatting addresses. The files affected are IdentityForm.vue, Teleport.vue, Drops.vue, ClaimForm.vue, Error.vue, and cookie-notice.vue.

🤖 Generated by Copilot at 04ef6a6

<p> tags replaced
with <h1> for accessibility
a winter project

@daiagi daiagi requested a review from a team as a code owner August 30, 2023 08:59
@daiagi daiagi requested review from stephenjason89 and floyd-li and removed request for a team August 30, 2023 08:59
@kodabot
Copy link
Collaborator

kodabot commented Aug 30, 2023

SUCCESS @daiagi PR for issue #7002 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Aug 30, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 04ef6a6
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/64ef04e20154180008adca6e
😎 Deploy Preview https://deploy-preview-7040--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Aug 30, 2023

AI-Generated Summary: This pull request introduces several updates to various components of the application, primarily focused on the semantic HTML elements. There's an emphasis on changing <p> and <div> tags to <h1> tags, and <h1> to <h3>, which would improve the SEO and assist screen-readers. Also, some redundant imports are removed to clean the code. The components that have seen changes include the Teleport, CookieNotice, ClaimForm, Error, IdentityForm, Drops and a few others. Additionally, this pull request addresses linting issues raised by Sonar.

@codeclimate
Copy link

codeclimate bot commented Aug 30, 2023

Code Climate has analyzed commit 04ef6a6 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Aug 30, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@vikiival
Copy link
Member

vikiival commented Aug 30, 2023

Is this for semantic purposes or Unification across the pages?

@yangwao
Copy link
Member

yangwao commented Aug 30, 2023

image you posted in the issue is largly inaccurate, many of the pages did have a proper h1 already

Yes, it's ahref tooling sometimes has misreadings. Even it classifies we have broken image pictures going to .webp however when I click on them they works!

We are aim to get back our health score of main domain back on legs! :)
thank you!

Is this for semantic purposes

^ @vikiival

@yangwao
Copy link
Member

yangwao commented Aug 30, 2023

pay 50 usd

@yangwao yangwao merged commit 842351e into main Aug 30, 2023
16 checks passed
@yangwao yangwao deleted the chore/h1 branch August 30, 2023 11:46
@yangwao
Copy link
Member

yangwao commented Aug 30, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.58 USD/DOT ~ 10.917 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0x635b805df5c617ee91d013370c275382c704905b3925a9232529bbb486067ca6

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Aug 30, 2023
This was referenced Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

H1 tag missing or empty
5 participants