-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Playwright tests and modifications #7267
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request contains six patches that primarily focus on adding data-testids for end-to-end testing on various components such as the footer, create-collection, search, and search-suggestion components. Additionally, patches include a relocation of a fixture image used for end-to-end testing and the addition of new comprehensive tests for createcollection, footer, and searching functionality. Minor adjustments were made on pre-existing tests such as changing the waiting time and adding page loading in the language and redirect tests, respectively. |
Reviewpad Report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will make the changes, ty. edit: is already active for tests inside same file |
reduced by 30s, lmk if that works |
This reverts commit 48633a5.
This reverts commit 43b9a63.
This reverts commit b8131f0.
This reverts commit ca7a022.
This reverts commit ce22e19.
This reverts commit 31ed0ac.
This reverts commit 1b6c0db.
This reverts commit 21f12ef.
This reverts commit 4db8a75.
This reverts commit 512bb0d.
This reverts commit 3596fd0.
This reverts commit 76abf6f.
Report:
|
Code Climate has analyzed commit ee485d5 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
Some new automated test coverage, will be improved in the future.
reason why i did not use for-each:
MerchShop was failing when waiting for page to load, so i took it off for now
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Community participation
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at de69f56
Added
data-testid
attributes to various components for Playwright testing. Added new tests for collection creation, footer, and search functionality. Improved some existing tests for language and redirect by increasing timeouts and waiting for page load.🤖 Generated by Copilot at de69f56