-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fa sharp regular as default icon #7302
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request contains changes across numerous files, primarily centered around icon usage within Vue.js components. Components like "NeoInput", "NeoButton", "NeoIcon", and others have seen the removal or amendment of icon related attributes, namely 'iconPack', 'pack', and 'icon-pack'. The majority of changes are superficial, mainly involving changes to display attributes rather than to core functionality. In many cases, the icons' pack value (previously set as 'fas', 'far', or 'fa-sharp') has been removed or updated to 'fasr', indicating a potential shift in the default pack value within the components themselves. In some cases, the structure of the HTML has been simplified for readability, with multiple attributes being condensed to a single line. Three FontAwesome dependencies have been removed from the The 'pnpm-lock.yaml' file also reflects these package removals and includes additional changes to some version numbers. Ensure that these changes are properly tested and verified not to affect the UI significantly or introduce inconsistencies in the interface's visual aspects. The removal of these attributes should not affect the functionality of the icons, but it may alter their appearance, which should be carefully reviewed. |
Reviewpad Report
|
after changes that prury mentioned, feel free to merge |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Code Climate has analyzed commit 3f299ac and detected 0 issues on this pull request. View more on Code Climate. |
Oh, intended. This is the one that I am trying to fix in this PR. Previously, by default, we used fixed |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
fasr
. in case some of icons intended to usefass
feel free to create a new PRDid your issue had any of the "$" label on it?
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at 6e473db
Refactored several components to use reusable components and a new icon pack for
NeoIcon
andNeoButton
components. This improves the code quality, consistency, and performance of the UI. Removed unnecessarypack
andicon-pack
props from various components that use the default icon pack. Moved some code fromDropContainer.vue
andBlogPost.vue
toNavbar.vue
to create reusable components for displaying drop-related and blog-related information.🤖 Generated by Copilot at 6e473db