Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fa sharp regular as default icon #7302

Merged
merged 4 commits into from
Sep 26, 2023
Merged

chore: fa sharp regular as default icon #7302

merged 4 commits into from
Sep 26, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Sep 19, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at 6e473db

Refactored several components to use reusable components and a new icon pack for NeoIcon and NeoButton components. This improves the code quality, consistency, and performance of the UI. Removed unnecessary pack and icon-pack props from various components that use the default icon pack. Moved some code from DropContainer.vue and BlogPost.vue to Navbar.vue to create reusable components for displaying drop-related and blog-related information.

🤖 Generated by Copilot at 6e473db

Sing, O Muse, of the glorious pull request
That simplified the code of NeoIcon and NeoButton
And removed the needless pack and icon-pack props
That burdened the components with redundant attributes.

@netlify
Copy link

netlify bot commented Sep 19, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 3f299ac
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65115afe9aba2a0008e344a1
😎 Deploy Preview https://deploy-preview-7302--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 19, 2023

AI-Generated Summary: This pull request contains changes across numerous files, primarily centered around icon usage within Vue.js components. Components like "NeoInput", "NeoButton", "NeoIcon", and others have seen the removal or amendment of icon related attributes, namely 'iconPack', 'pack', and 'icon-pack'.

The majority of changes are superficial, mainly involving changes to display attributes rather than to core functionality. In many cases, the icons' pack value (previously set as 'fas', 'far', or 'fa-sharp') has been removed or updated to 'fasr', indicating a potential shift in the default pack value within the components themselves.

In some cases, the structure of the HTML has been simplified for readability, with multiple attributes being condensed to a single line. Three FontAwesome dependencies have been removed from the package.json file, and numerous specific icon imports from these libraries have been removed from the icons.ts file. The icon handling mechanism replaced this with a plugin setup that allows for increased flexibility and ease of use.

The 'pnpm-lock.yaml' file also reflects these package removals and includes additional changes to some version numbers.

Ensure that these changes are properly tested and verified not to affect the UI significantly or introduce inconsistencies in the interface's visual aspects. The removal of these attributes should not affect the functionality of the icons, but it may alter their appearance, which should be carefully reviewed.

@reviewpad reviewpad bot added the large Pull request is large label Sep 19, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 19, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@preschian preschian changed the title chore: fa sharp as default icon chore: fa sharp regular as default icon Sep 19, 2023
@preschian preschian marked this pull request as ready for review September 19, 2023 13:24
@preschian preschian requested a review from a team as a code owner September 19, 2023 13:24
@preschian preschian requested review from roiLeo and floyd-li and removed request for a team September 19, 2023 13:24
@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Sep 20, 2023
@prury prury requested a review from exezbcz September 21, 2023 16:11
@prury
Copy link
Member

prury commented Sep 21, 2023

  • smaller than it was on canary:
    image

  • not loading:
    image

  • smaller than it was on canary:
    image

  • massmint new icon not taking proper space
    image

  • many icons got this change(nut sure if that's a problem tho):

icon.change.mp4

@roiLeo
Copy link
Contributor

roiLeo commented Sep 21, 2023

Legolas_What_Do_Your_Elf_Eyes_See_banner.jpg

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Sep 21, 2023
@exezbcz
Copy link
Member

exezbcz commented Sep 21, 2023

after changes that prury mentioned, feel free to merge

@sonarcloud
Copy link

sonarcloud bot commented Sep 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codeclimate
Copy link

codeclimate bot commented Sep 25, 2023

Code Climate has analyzed commit 3f299ac and detected 0 issues on this pull request.

View more on Code Climate.

@preschian
Copy link
Member Author

preschian commented Sep 25, 2023

  • many icons got this change(nut sure if that's a problem tho):

icon.change.mp4

Oh, intended. This is the one that I am trying to fix in this PR. Previously, by default, we used fa classic solid. in this PR, I change it to fa sharp regular.
before: https://fontawesome.com/icons/share-alt?f=classic&s=solid
after: https://fontawesome.com/icons/share-alt?f=sharp&s=regular

  • smaller than it was on canary:
    image
  • not loading:
    image
  • smaller than it was on canary:
    image
  • massmint new icon not taking proper space
    image

fixed

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Sep 25, 2023
@yangwao yangwao merged commit 0abee85 into main Sep 26, 2023
14 checks passed
@yangwao yangwao deleted the chore/fa-sharp-icons branch September 26, 2023 11:23
@yangwao yangwao mentioned this pull request Sep 27, 2023
@yangwao yangwao mentioned this pull request Sep 27, 2023
@preschian preschian mentioned this pull request Sep 28, 2023
6 tasks
This was referenced Sep 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants