Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test time improvement: Sharding #7314

Closed
wants to merge 15 commits into from
Closed

Conversation

prury
Copy link
Member

@prury prury commented Sep 21, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Test: Sharding

Context

Copilot Summary

🤖 Generated by Copilot at 3a26442

This pull request enhances the Playwright tests for the NFT gallery by enabling parallel execution, disabling automatic HTML report opening, and using more precise URL assertions.

🤖 Generated by Copilot at 3a26442

Sing, O Muse, of the valiant deeds of the testers
Who with Playwright's skillful tools and cunning config
Tamed the unruly browser, reporter of their glory
And made it silent and obedient to their will.

@netlify
Copy link

netlify bot commented Sep 21, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 1490160
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/650da3854e8b130008a7b734
😎 Deploy Preview https://deploy-preview-7314--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 21, 2023

AI-Generated Summary: This pull request involves two main changes to the codebase. The first change includes setting up a fail-fast strategy in the playwright.yml file. It also implements sharding in the test processes, dividing the tests into four parts to minimize total testing time. The second change modifies the playwright.config.ts file to adjust the reporting options of Playwright tests. The configuration now ensures that the HTML report doesn't automatically open upon generation.

@reviewpad reviewpad bot added the small Pull request is small label Sep 21, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 21, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@prury prury marked this pull request as ready for review September 21, 2023 16:12
@prury prury requested a review from a team as a code owner September 21, 2023 16:12
@prury prury requested review from preschian and roiLeo and removed request for a team September 21, 2023 16:12
@prury prury marked this pull request as draft September 21, 2023 21:56
@codeclimate
Copy link

codeclimate bot commented Sep 22, 2023

Code Climate has analyzed commit 1490160 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Sep 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prury prury closed this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant