-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Listing price: I set the price 1 DOT it listed item for 100 DOTs #7347
Conversation
SUCCESS @Jarsen136 PR for issue #7343 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime! |
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request fixes an issue in the code related to listing prices in the application. Previously, when setting the price as 1 DOT, it would list the item for 100 DOTs. This has been rectified by adjusting the line of code that calculates listing prices - now it also takes into account decimal values. The two main changes occur in the ListingCartModal.vue file, where 'decimals' was added to the 'useChain' hook and the balance calculation line was modified. |
@Jarsen136 I'm not sure if the problem comes from this PR, but transaction fails when i try to mint it, even if i have the proper balance on Asset Hub I was able to mint properly on canary although i could not reproduce Luuu issue |
Code Climate has analyzed commit e0e6299 and detected 0 issues on this pull request. View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
It's not related to this PR. I have not changed anything about minting on this PR. Would you mind trying again?
Listing any nft on ahp network could reproduce this bug. |
was able to reproduce now, only happens if you change listing price as shown in the issue video. |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Needs QA check
Context
Did your issue had any of the "$" label on it?
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at dad5d9a
Fixed list price display for different chains by using
decimals
fromuseChain
inListingCartModal.vue
.🤖 Generated by Copilot at dad5d9a