Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Listing price: I set the price 1 DOT it listed item for 100 DOTs #7347

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Sep 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at dad5d9a

Fixed list price display for different chains by using decimals from useChain in ListingCartModal.vue.

🤖 Generated by Copilot at dad5d9a

useChain has decimals
Balance shows list price right
Autumn of chains

@Jarsen136 Jarsen136 requested a review from a team as a code owner September 24, 2023 16:40
@Jarsen136 Jarsen136 requested review from stephenjason89 and floyd-li and removed request for a team September 24, 2023 16:40
@kodabot
Copy link
Collaborator

kodabot commented Sep 24, 2023

SUCCESS @Jarsen136 PR for issue #7343 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Sep 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit e0e6299
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65107a1c0cf65e0008dcfe83
😎 Deploy Preview https://deploy-preview-7347--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 24, 2023

AI-Generated Summary: This pull request fixes an issue in the code related to listing prices in the application. Previously, when setting the price as 1 DOT, it would list the item for 100 DOTs. This has been rectified by adjusting the line of code that calculates listing prices - now it also takes into account decimal values. The two main changes occur in the ListingCartModal.vue file, where 'decimals' was added to the 'useChain' hook and the balance calculation line was modified.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Sep 24, 2023
@prury
Copy link
Member

prury commented Sep 24, 2023

@Jarsen136 I'm not sure if the problem comes from this PR, but transaction fails when i try to mint it, even if i have the proper balance on Asset Hub

https://assethub-polkadot.subscan.io/tx/0x95edc539021ecc7dedcb2f8384166bf8970ada33fe5ed9e89269e149d3ce03f9

I was able to mint properly on canary although i could not reproduce Luuu issue

@codeclimate
Copy link

codeclimate bot commented Sep 24, 2023

Code Climate has analyzed commit e0e6299 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@Jarsen136
Copy link
Contributor Author

@Jarsen136 I'm not sure if the problem comes from this PR, but transaction fails when i try to mint it, even if i have the proper balance on Asset Hub

https://assethub-polkadot.subscan.io/tx/0x95edc539021ecc7dedcb2f8384166bf8970ada33fe5ed9e89269e149d3ce03f9

It's not related to this PR. I have not changed anything about minting on this PR. Would you mind trying again?

I was able to mint properly on canary although i could not reproduce Luuu issue

Listing any nft on ahp network could reproduce this bug.

@prury
Copy link
Member

prury commented Sep 25, 2023

@Jarsen136 I'm not sure if the problem comes from this PR, but transaction fails when i try to mint it, even if i have the proper balance on Asset Hub
https://assethub-polkadot.subscan.io/tx/0x95edc539021ecc7dedcb2f8384166bf8970ada33fe5ed9e89269e149d3ce03f9

It's not related to this PR. I have not changed anything about minting on this PR. Would you mind trying again?

I was able to mint properly on canary although i could not reproduce Luuu issue

Listing any nft on ahp network could reproduce this bug.

was able to reproduce now, only happens if you change listing price as shown in the issue video.
when minting + listing it doesn't occur.
anyway, made a test and it is fixed now, ty!

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Sep 25, 2023
@vikiival vikiival added this pull request to the merge queue Sep 26, 2023
Merged via the queue into kodadot:main with commit b93df56 Sep 26, 2023
14 checks passed
@yangwao yangwao mentioned this pull request Oct 11, 2023
@yangwao yangwao mentioned this pull request Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listing price: I set the price 1 DOT it listed item for 100 DOTs!
5 participants