Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Spotlight: AssetHub Kusama #7348

Merged
merged 2 commits into from
Sep 25, 2023
Merged

fix: Spotlight: AssetHub Kusama #7348

merged 2 commits into from
Sep 25, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Sep 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at 6e8de47

Added new curated collections for Arabic locale in useCarouselSpotlight.ts. This enables the carousel spotlight to show relevant collections for ahk users.

🤖 Generated by Copilot at 6e8de47

curatedCollection
Changes with the seasons, ahk
Spotlight carousel

@Jarsen136 Jarsen136 requested a review from a team as a code owner September 24, 2023 16:47
@Jarsen136 Jarsen136 requested review from preschian and daiagi and removed request for a team September 24, 2023 16:47
@kodabot
Copy link
Collaborator

kodabot commented Sep 24, 2023

SUCCESS @Jarsen136 PR for issue #7342 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Sep 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 385f132
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65106cd55019f40008026f87
😎 Deploy Preview https://deploy-preview-7348--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Sep 24, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 24, 2023

AI-Generated Summary: This pull request contains an update to the useCarouselSpotlight.ts file within the carousel component of the application. The patch adds a new collection titled ahk to the curatedCollection object in the mentioned file. The ahk collection contains an array of numerical keys that represent different entities such as 'MyGenArt', 'Rad Panda', 'Experience the scenic canyon drive', 'Emotional Devastation', 'threads (koda)', 'Season 23', and 'Forgive me not'.

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Sep 24, 2023
@codeclimate
Copy link

codeclimate bot commented Sep 24, 2023

Code Climate has analyzed commit 385f132 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@roiLeo roiLeo added this pull request to the merge queue Sep 25, 2023
Merged via the queue into kodadot:main with commit ff1f51a Sep 25, 2023
14 checks passed
This was referenced Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spotlight: AssetHub Kusama
5 participants