Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌍 typos in english translations #7368

Merged
merged 4 commits into from
Sep 26, 2023
Merged

🌍 typos in english translations #7368

merged 4 commits into from
Sep 26, 2023

Conversation

vikiival
Copy link
Member

@vikiival vikiival commented Sep 26, 2023

  • 🌐 🐛 broadcasting
  • 🌐 🐛 typos, wording

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Copilot Summary

🤖 Generated by Copilot at cbef1b9

This pull request improves the English localization of the NFT gallery app by correcting typos and grammar in ./locales/en.json and updating the information about a third-party NFT marketplace.

🤖 Generated by Copilot at cbef1b9

The file ./locales/en.json
Had some errors that needed correction
So this pull request
Made the text more exact
And added a new NFT marketplace section

@vikiival vikiival requested a review from a team as a code owner September 26, 2023 10:23
@vikiival vikiival requested review from stephenjason89 and floyd-li and removed request for a team September 26, 2023 10:23
@netlify
Copy link

netlify bot commented Sep 26, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 6cdedf0
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6512d858c7a9d4000700700d
😎 Deploy Preview https://deploy-preview-7368--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Sep 26, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 26, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Sep 26, 2023

Code Climate has analyzed commit cbef1b9 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Sep 26, 2023

AI-Generated Summary: This pull request contains two patches that mainly focus on fixing typos and improving the wording in the 'locales/en.json' file.

The first patch corrects the spelling error in the word "broadcast", which was incorrectly typed as 'broadcating', resulting in unclear action description.

The second patch makes extensive changes to the language used in the file: it corrects grammatical errors, makes style improvements for better clarity and consistency, and updates some text to reflect changes in the context or functionality. Also, there are changes in the names of certain NFT marketplaces. It's a comprehensive review of the wording to enhance user understanding.

locales/en.json Outdated Show resolved Hide resolved
locales/en.json Outdated Show resolved Hide resolved
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Sep 26, 2023
vikiival and others added 2 commits September 26, 2023 15:10
Co-authored-by: Ramo <36627808+prury@users.noreply.github.com>
Co-authored-by: roiLeo <medina.leo42@gmail.com>
@vikiival vikiival merged commit 59f850e into main Sep 26, 2023
6 of 8 checks passed
@vikiival vikiival deleted the typos branch September 26, 2023 13:11
@sonarcloud
Copy link

sonarcloud bot commented Sep 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

This was referenced Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants