Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netlify Deploy Button for Kodadot-app #1397 #7508

Closed
wants to merge 7 commits into from
Closed

Netlify Deploy Button for Kodadot-app #1397 #7508

wants to merge 7 commits into from

Conversation

AshutoshSingh72
Copy link
Contributor

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

Problems

I tried to list Kodadot NFT gallery tamplate on https://www.netlify.com/integrations/templates/
But https://github.com/netlify/templates this Template Git hub Repo is Archived but i tried to make pull request but because it is archived i wan't able to pull
IMG_20231004_172752

View my Template
md file https://github.com/AshutoshSingh72/templates/blob/master/src/site/template/Kodadot-nft-gallery.md

Fixes

But i was able able to build the netlify deploy button added it into the contributor md

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

@AshutoshSingh72 AshutoshSingh72 requested a review from a team as a code owner October 5, 2023 03:18
@AshutoshSingh72 AshutoshSingh72 requested review from preschian and Jarsen136 and removed request for a team October 5, 2023 03:18
@kodabot
Copy link
Collaborator

kodabot commented Oct 5, 2023

SUCCESS @AshutoshSingh72 PR for issue #1397 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit 81a46a2
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/651ebc92645a5b0008b38145
😎 Deploy Preview https://deploy-preview-7508--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 5, 2023

AI-Generated Summary: This pull request consists of two patches targeting the CONTRIBUTING.md file. The first patch adds three lines of code, providing instructions on how to deploy the Kodadot NFT Gallery on Netlify, complete with a deploy button. The second patch changes a single line of text, specifically, it tweaks the wording from "on Netlify" to "to Netlify" in the deployment instructions.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review docs labels Oct 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@preschian preschian requested a review from yangwao October 5, 2023 05:48
Copy link
Member

@vikiival vikiival left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Viki Val <viktorko99@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@AshutoshSingh72
Copy link
Contributor Author

AshutoshSingh72 commented Oct 5, 2023

@AshutoshSingh72
Copy link
Contributor Author

@AshutoshSingh72
Copy link
Contributor Author

Cc @yangwao @vikiival

@vikiival
Copy link
Member

vikiival commented Oct 9, 2023

Hello,
the solution that you provided does not work ^-^
Please take high issue with a higher priority

Screenshot 2023-10-09 at 12 08 49

@vikiival vikiival closed this Oct 9, 2023
@AshutoshSingh72
Copy link
Contributor Author

Hello, the solution that you provided does not work ^-^ Please take high issue with a higher priority

Screenshot 2023-10-09 at 12 08 49

I'm using the same deploy button and it is working https://6523f73dadb3140a638f697e--melodic-cheesecake-9489e5.netlify.app/

@AshutoshSingh72
Copy link
Contributor Author

Hello, the solution that you provided does not work ^-^ Please take high issue with a higher priority

Screenshot 2023-10-09 at 12 08 49

Screenshot_2023-10-09-18-36-31-80

@vikiival
Copy link
Member

vikiival commented Oct 9, 2023

Looks a residual from some old repository

https://app.netlify.com/sites/joyful-douhua-7de1e0/deploys/6523fb58dae19f089b306ed0

please anyway open new pr with correct commit description.

@vikiival
Copy link
Member

vikiival commented Oct 9, 2023

Yup looks like its working

Screenshot 2023-10-09 at 15 14 03

I had some residual repository.

Reasons Why I closed this PR:
Sir well you do not follow the contributing standards 🙂

  1. 7 same commits
  2. Not using PR template
  3. Screenshots not provided
  4. Issue Create kodadot-app Netlify Deploy Button #1397 was created almost 2yrs ago

@AshutoshSingh72
Copy link
Contributor Author

Yup looks like its working

Screenshot 2023-10-09 at 15 14 03 I had some residual repository.

Reasons Why I closed this PR: Sir well you do not follow the contributing standards 🙂

  1. 7 same commits
  2. Not using PR template
  3. Screenshots not provided
  4. Issue Create kodadot-app Netlify Deploy Button #1397 was created almost 2yrs ago

bro for me i'm working here to solve some problems i faced first time joining kodadot contributors so it might be the oldest issue but it is a big deal for new contributors who stuck on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create kodadot-app Netlify Deploy Button
3 participants