Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 galleryItem price #7513

Merged
merged 1 commit into from
Oct 5, 2023
Merged

🔧 galleryItem price #7513

merged 1 commit into from
Oct 5, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 5, 2023

Screenshot 2023-10-05 at 10-45-25 KodaDot - NFT Market Explorer
Screenshot 2023-10-05 at 10-45-09 Rare Dolphin One Stop Shop for Polkadot NFTs

@roiLeo roiLeo requested a review from a team as a code owner October 5, 2023 08:45
@roiLeo roiLeo requested review from floyd-li and Jarsen136 and removed request for a team October 5, 2023 08:45
@netlify
Copy link

netlify bot commented Oct 5, 2023 •
edited
Loading

✅ Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit 5138088
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/651e77c2c512c00008494629
😎 Deploy Preview https://deploy-preview-7513--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 5, 2023

AI-Generated Summary: This pull request contains changes to the GalleryItemActionSection.vue file in the GalleryItemAction module. The changes consist of a few updates and improvements to code involving the formatting and setting of prices. The "withoutDigitSeparator" import has been removed while others have been left intact. The code block that gets the approximate price and does calculations has been refined as per error handling and code efficiency, with certain variables having their types changed. These optimizations mainly revolve around the calculation of a 'price' variable as well as its subsequent use to update the 'priceUsd' and 'priceChain' variables.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 5, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 5, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@roiLeo roiLeo merged commit 1412734 into kodadot:nuxt Oct 5, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floyd-li floyd-li Awaiting requested review from floyd-li floyd-li was automatically assigned from kodadot/code-review-guild

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 was automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roiLeo