Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: carousel arrow #7516

Merged
merged 2 commits into from
Oct 5, 2023
Merged

fix: carousel arrow #7516

merged 2 commits into from
Oct 5, 2023

Conversation

preschian
Copy link
Member

@preschian preschian commented Oct 5, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Did your issue had any of the "$" label on it?

Copilot Summary

🤖 Generated by Copilot at 7546f15

Refactored and improved the carousel component using reactive refs and keen-slider plugins. Fixed a build error and extracted a plugin function to a separate file. Affected files: CarouselAgnostic.vue, useCarousel.ts, CarouselWheelsPlugin.ts.

🤖 Generated by Copilot at 7546f15

The carousel component was slow
So they gave it a keen-slider glow
They used reactive refs
And some plugins for heft
And CarouselWheelsPlugin stole the show

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit 7546f15
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/651e8cb0812ced0007264770
😎 Deploy Preview https://deploy-preview-7516--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 5, 2023

AI-Generated Summary: This pull request includes two patches, both focused on refactoring existing code.

The first patch modifies the useCarousel.ts file. It renames the exported function wheelControls to CarouselWheelsPlugin.

The second patch is more extensive and modifies CarouselAgnostic.vue, a Vue component related to the carousel feature. Among the changes, it updates dependencies and improves the component structure by decluttering the exported function sliderSettings. It also changes the references to the same within the file to correspond with the updated function.

The restructuring in CarouselAgnostic.vue enhances readability and maintainability. Both of these patches contribute towards better code organization and improved structure.

@reviewpad reviewpad bot added the small Pull request is small label Oct 5, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 5, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@preschian preschian marked this pull request as ready for review October 5, 2023 10:20
@preschian preschian requested a review from a team as a code owner October 5, 2023 10:20
@preschian preschian requested review from roiLeo and floyd-li and removed request for a team October 5, 2023 10:20
@yangwao yangwao merged commit fdb090d into nuxt Oct 5, 2023
10 checks passed
@yangwao yangwao deleted the fix/carousel-arrow branch October 5, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants