Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 Holders activity tab #7521

Merged
merged 1 commit into from
Oct 5, 2023
Merged

🔧 Holders activity tab #7521

merged 1 commit into from
Oct 5, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 5, 2023

Capture d’écran 2023-10-05 à 2 55 50 PM

⚠️ we will have some issue with large collection
Capture d’écran 2023-10-05 à 2 51 47 PM

@roiLeo roiLeo requested a review from a team as a code owner October 5, 2023 12:57
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team October 5, 2023 12:57
@netlify
Copy link

netlify bot commented Oct 5, 2023 •
edited
Loading

✅ Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit 959d882
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/651eb2b220e69f00082b1a7c
😎 Deploy Preview https://deploy-preview-7521--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 5, 2023

AI-Generated Summary: This pull request introduces logging within the ownerInsightsTabs/HolderTab.vue and useCollectionActivity.ts files, applying four additions in each. Within the HolderTab.vue file, an onMounted hook is added to log the properties of the owners. In the useCollectionActivity.ts file, console.log(data) is added as well as edits to the watch data function to check for result rather than result.value.collection, resulting in similar amendments throughout the useCollectionActivity.ts file. Effectively, this results in a more comprehensive debug log and a minor alteration to error checking in the watch function.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@roiLeo roiLeo merged commit e4198a2 into kodadot:nuxt Oct 5, 2023
10 of 12 checks passed
@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian Awaiting requested review from preschian preschian was automatically assigned from kodadot/code-review-guild

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 was automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Collection activity doesnt load on nuxt
2 participants
@roiLeo @prury