Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 search collection hide suggestion #7533

Merged
merged 1 commit into from
Oct 6, 2023
Merged

🔧 search collection hide suggestion #7533

merged 1 commit into from
Oct 6, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 6, 2023

@roiLeo roiLeo requested a review from a team as a code owner October 6, 2023 07:23
@roiLeo roiLeo requested review from preschian and Jarsen136 and removed request for a team October 6, 2023 07:23
@netlify
Copy link

netlify bot commented Oct 6, 2023 •
edited
Loading

✅ Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit dc05806
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/651fb5f1d400b500081a3e8c
😎 Deploy Preview https://deploy-preview-7533--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roiLeo roiLeo merged commit 0d3c00e into kodadot:nuxt Oct 6, 2023
6 of 10 checks passed
@roiLeo roiLeo deleted the fix/search/collection branch October 6, 2023 07:23
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 6, 2023

AI-Generated Summary: This pull request includes changes in two files: SearchBar.vue and pnpm-lock.yaml. In SearchBar.vue, the condition check for isCollectionSearchMode has been relocated from SearchSuggestion to a higher-level template. This modification may result in potentially significant changes in behavior or output, depending on the template's conditions and how they are handled. So, it ensures the search suggestion only shows in a non-collection search mode. For pnpm-lock.yaml, the lockfileVersion has been updated from '6.0' to '6.1'. This potentially signifies an update in the project's dependencies or package configurations.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 6, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 6, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian Awaiting requested review from preschian preschian was automatically assigned from kodadot/code-review-guild

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 was automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roiLeo