Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 highest offer #7551

Merged
merged 1 commit into from
Oct 8, 2023
Merged

🔧 highest offer #7551

merged 1 commit into from
Oct 8, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 8, 2023

TESTED on /bsx/gallery/282897835-6

before
Screenshot 2023-10-08 at 15-47-17 KodaDot - NFT Market Explorer

after
Screenshot 2023-10-08 at 15-37-49 KodaDot - NFT Market Explorer

@roiLeo roiLeo requested a review from a team as a code owner October 8, 2023 13:47
@roiLeo roiLeo requested review from preschian and daiagi and removed request for a team October 8, 2023 13:47
@netlify
Copy link

netlify bot commented Oct 8, 2023 •
edited
Loading

✅ Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit 65f144d
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/6522b2f6af520a0007a32ba3
😎 Deploy Preview https://deploy-preview-7551--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 8, 2023

AI-Generated Summary: This pull request modifies the GalleryItemActionSection.vue component in the gallery module. Previously, the asynchronous operation to get the approximate price was always executed. Now, an additional conditional statement has been added so that the asynchronous function will only run if props.price is provided. This helps to prevent unnecessary requests and potential errors when the props.price value isn't set.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 8, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 8, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@sonarcloud
Copy link

sonarcloud bot commented Oct 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@roiLeo roiLeo merged commit 1c3f63f into kodadot:nuxt Oct 8, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian Awaiting requested review from preschian preschian was automatically assigned from kodadot/code-review-guild

@daiagi daiagi Awaiting requested review from daiagi daiagi was automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roiLeo