Programatic drops #7570

Jarsen136 · 2023-10-10T05:49:28Z

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Needs QA check

@kodadot/qa-guild please review

Context

Closes Programatic drops #7194
Requires deployment <snek/rubick/worker>

Did your issue had any of the "$" label on it?

My DOT address: Payout

Screenshot 📸

My fix has changed UI

Copilot Summary

`🤖 Generated by Copilot at f56cf48`

No summary available (Limit exceeded: required to process 97572 tokens, but only 50000 are allowed per call)

`🤖 Generated by Copilot at c5c0c36`

Oh we're the crew of Kodadot, and we're sailing on the web
We're fetching drops and collections, from the useDrops hook
We're refactoring our components, to use the drop prop
And we're changing all the prefixes, from ahk to ahp

kodabot · 2023-10-10T05:49:32Z

WARNING @Jarsen136 PR for issue #7194 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #7194

netlify · 2023-10-10T05:49:33Z

✅ Deploy Preview for nuxt-kodadot ready!

Name	Link
🔨 Latest commit	`aae485c`
🔍 Latest deploy log	https://app.netlify.com/sites/nuxt-kodadot/deploys/65257bb72f3a700008a8b387
😎 Deploy Preview	https://deploy-preview-7570--nuxt-kodadot.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

reviewpad · 2023-10-10T05:50:35Z

AI-Generated Summary: This pull request came with a lot of modifications spread out on various sectors of the codebase. The primary focus of these changes seems to be the simplification and standardization of how drops are handled and displayed across the platform.

To summarize:

Various .vue files saw significant refactoring, mainly concentrating on transitions from hard-coded variables to dynamic values coming from newly created prop drop which is an object of type DropItem. This change improves scalability, readability, and maintainability of the code.
Code related to drop links as well as some layout features were updated or removed as part of the refactoring process.
The way the Referendum Vote is checked was modified to be more flexible.
The getDrops and getDropById functions were added to the 'waifu.ts' file, enhancing the functionality of fetching drops.
There's been the introduction of two new type aliases, DropType and DropItem, in 'params/types', establishing a standardized way to refer and manage drop data across different components.
Several files and constants for specific drop types were removed as part of this streamlining process, including certain pages and global redirect rules.
A new Vue component was created to display different types of collection drops based on the dropType.
The English locale file, en.json, received a new term 'Free', hinting at the introduction of a new feature.
A make-shift amendment was made to the routing in way to redirect users to a new 'berlin-drop' page.
The 'UnlockableCollectionBanner' component is no longer used and has been removed from several sections of the codebase.
Improvements were made to the 'useDrops' function where it was entirely reworked so that it could load all drops on component mounting by running the getDrops function.
Updates were made to the GraphQL query named referendumVoteByAccount's to include a new variable $proposal of type Number. This makes the query dynamic, more reusable and able to handle different proposal values instead of the hardcoded 93.

In all, this appears to be a substantial refactoring effort that shifts the platform towards a cleaner, more scalable code along with potentially some new features.

Jarsen136 · 2023-10-10T09:24:04Z

Could you please add the preview env to the cors header? @vikiival

vikiival · 2023-10-10T10:30:35Z

Could you please add the preview env to the cors header? @vikiival

Updated ^-^

yangwao · 2023-10-10T11:17:14Z

huge! looking forward to see this merged
pay 80 usd

yangwao · 2023-10-10T11:17:25Z

😍 Perfect, I’ve sent the payout
💵 $80 @ 3.82 USD/DOT ~ 20.942 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x7d465f547af9806eedb3c32ed1c152c2f5e0537c650dd308788084c8d8b45100

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

vikiival · 2023-10-10T22:01:39Z

Yup account is out of balance :) i will pass some tokens to it

netlify · 2023-10-11T14:34:22Z

✅ Deploy Preview for koda-canary ready!

Name	Link
🔨 Latest commit	`dcbfbc1`
🔍 Latest deploy log	https://app.netlify.com/sites/koda-canary/deploys/6527a6c0150ae80008d5a24b
😎 Deploy Preview	https://deploy-preview-7570--koda-canary.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

composables/drop/useCheckReferenDumVote.ts

roiLeo

otherwise code lgtm ✅

components/collection/unlockable/UnlockableContainer.vue

components/collection/unlockable/UnlockableLandingTag.vue

components/drops/DropCard.vue

components/drops/useDrops.ts

layouts/unlockable-mint-layout.vue

pages/[prefix]/drops/[id].vue

Co-authored-by: roiLeo <medina.leo42@gmail.com>

layouts/unlockable-mint-layout.vue

…e-7194

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

preschian

otherwise lgtm

pages/[prefix]/drops/[id].vue

components/collection/drop/TokenImportButton.vue

…e-7194

codeclimate · 2023-10-12T07:57:16Z

Code Climate has analyzed commit dcbfbc1 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category	Count
Complexity	1

View more on Code Climate.

sonarcloud · 2023-10-12T07:57:41Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

vikiival · 2023-10-12T11:31:22Z

It happens in canary env also. After some research, I found there are some errors on-chain. @vikiival Could you please take a look?

Updated with 60 DOT :)

prury · 2023-10-12T12:15:36Z

Free drop fails when minting, but it was failing already on canary, lmk if new issue is needed
Dot drop working ✔️

vikiival · 2023-10-12T12:17:40Z

Free drop fails when minting, but it was failing already on canary, lmk if new issue is needed

Maybe because 1 per addr rule?

prury · 2023-10-12T12:18:31Z

Free drop fails when minting, but it was failing already on canary, lmk if new issue is needed

Maybe because 1 per addr rule?

~~tried with fresh account~~
edit: it was not so fresh, created another and it worked

vikiival · 2023-10-12T12:28:23Z

Free drop fails when minting, but it was failing already on canary, lmk if new issue is needed

We should open issue for more friendly errors ^-^

prury · 2023-10-12T12:32:19Z

Free drop fails when minting, but it was failing already on canary, lmk if new issue is needed

We should open issue for more friendly errors ^-^

uh, sorry, i did not understood what you mean

Jarsen136 added 10 commits September 7, 2023 23:44

Merge branch 'main' into issue-6615

97eb615

Merge branch 'main' into issue-7194

ab1305f

feat: drop list

e395b03

Merge branch 'main' into issue-7194

ef0a9e4

feat: drops list

739f259

refacotr: drop details

eabaf42

Merge branch 'nuxt' into issue-7194

c122c5b

refactor: drop item details

5e0f829

refactor: drop banner

c3c39e1

refactor: drop collection

f56cf48

Merge branch 'nuxt' into issue-7194

2446a46

reviewpad bot added the large Pull request is large label Oct 10, 2023

Jarsen136 added 2 commits October 10, 2023 17:22

fix: redirect prefix

2cb198e

fix: vote drop

c5c0c36

Jarsen136 marked this pull request as ready for review October 10, 2023 09:24

Jarsen136 requested a review from a team as a code owner October 10, 2023 09:24

Jarsen136 requested review from preschian, roiLeo and vikiival and removed request for a team October 10, 2023 09:24

reviewpad bot added the waiting-for-review label Oct 10, 2023

Merge branch 'nuxt' into issue-7194

e63f2c8

yangwao added the paid pull-request has been paid label Oct 10, 2023

yangwao changed the base branch from nuxt to main October 10, 2023 16:37

Merge branch 'main' into issue-7194

0c69bfb

codeclimate bot reviewed Oct 11, 2023

View reviewed changes

composables/drop/useCheckReferenDumVote.ts Show resolved Hide resolved

roiLeo approved these changes Oct 12, 2023

View reviewed changes

roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Oct 12, 2023

Jarsen136 and others added 2 commits October 12, 2023 15:09

Update components/drops/DropCard.vue

88733d2

Co-authored-by: roiLeo <medina.leo42@gmail.com>

Update layouts/unlockable-mint-layout.vue

6f363dc

Co-authored-by: roiLeo <medina.leo42@gmail.com>

github-actions bot reviewed Oct 12, 2023

View reviewed changes

layouts/unlockable-mint-layout.vue Outdated Show resolved Hide resolved

Jarsen136 and others added 3 commits October 12, 2023 15:18

chore: span to div

cde38d5

Merge branch 'issue-7194' of github.com:kodadot/nft-gallery into issu…

0f831a4

…e-7194

Update layouts/unlockable-mint-layout.vue

b60c539

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

preschian approved these changes Oct 12, 2023

View reviewed changes

pages/[prefix]/drops/[id].vue Outdated Show resolved Hide resolved

components/collection/drop/TokenImportButton.vue Outdated Show resolved Hide resolved

Jarsen136 added 2 commits October 12, 2023 15:56

fix: drop price

5a3a81f

Merge branch 'issue-7194' of github.com:kodadot/nft-gallery into issu…

dcbfbc1

…e-7194

Jarsen136 requested a review from prury October 12, 2023 11:32

prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Oct 12, 2023

vikiival merged commit 3a855eb into main Oct 12, 2023
13 of 14 checks passed

vikiival deleted the issue-7194 branch October 12, 2023 12:44

vikiival mentioned this pull request Oct 12, 2023

More friendly errors for drops page #7624

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Programatic drops #7570

Programatic drops #7570

Jarsen136 commented Oct 10, 2023 •

edited

Loading

kodabot commented Oct 10, 2023

netlify bot commented Oct 10, 2023 •

edited

Loading

reviewpad bot commented Oct 10, 2023

Jarsen136 commented Oct 10, 2023

vikiival commented Oct 10, 2023

yangwao commented Oct 10, 2023

yangwao commented Oct 10, 2023

vikiival commented Oct 10, 2023

netlify bot commented Oct 11, 2023 •

edited

Loading

roiLeo left a comment

preschian left a comment

codeclimate bot commented Oct 12, 2023

sonarcloud bot commented Oct 12, 2023

vikiival commented Oct 12, 2023

prury commented Oct 12, 2023

vikiival commented Oct 12, 2023

prury commented Oct 12, 2023 •

edited

Loading

vikiival commented Oct 12, 2023

prury commented Oct 12, 2023

Programatic drops #7570

Programatic drops #7570

Conversation

Jarsen136 commented Oct 10, 2023 • edited Loading

PR Type

Needs QA check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

Copilot Summary

🤖 Generated by Copilot at f56cf48

🤖 Generated by Copilot at c5c0c36

kodabot commented Oct 10, 2023

netlify bot commented Oct 10, 2023 • edited Loading

✅ Deploy Preview for nuxt-kodadot ready!

reviewpad bot commented Oct 10, 2023

Jarsen136 commented Oct 10, 2023

vikiival commented Oct 10, 2023

yangwao commented Oct 10, 2023

yangwao commented Oct 10, 2023

vikiival commented Oct 10, 2023

netlify bot commented Oct 11, 2023 • edited Loading

✅ Deploy Preview for koda-canary ready!

roiLeo left a comment

Choose a reason for hiding this comment

preschian left a comment

Choose a reason for hiding this comment

codeclimate bot commented Oct 12, 2023

sonarcloud bot commented Oct 12, 2023

vikiival commented Oct 12, 2023

prury commented Oct 12, 2023

vikiival commented Oct 12, 2023

prury commented Oct 12, 2023 • edited Loading

vikiival commented Oct 12, 2023

prury commented Oct 12, 2023

Jarsen136 commented Oct 10, 2023 •

edited

Loading

`🤖 Generated by Copilot at f56cf48`

`🤖 Generated by Copilot at c5c0c36`

netlify bot commented Oct 10, 2023 •

edited

Loading

netlify bot commented Oct 11, 2023 •

edited

Loading

prury commented Oct 12, 2023 •

edited

Loading