Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 isDarkMode #7573

Merged
merged 1 commit into from
Oct 10, 2023
Merged

🔧 isDarkMode #7573

merged 1 commit into from
Oct 10, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 10, 2023

@roiLeo roiLeo requested a review from a team as a code owner October 10, 2023 07:32
@roiLeo roiLeo requested review from daiagi and Jarsen136 and removed request for a team October 10, 2023 07:32
@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

✅ Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit 68b91e9
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/6524fe08c7d1f400088fa493
😎 Deploy Preview https://deploy-preview-7573--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roiLeo roiLeo requested review from hassnian and a team October 10, 2023 07:32
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 10, 2023

AI-Generated Summary: This pull request simplifies the isDarkMode function in the useTheme.ts file. The function now only checks if colorMode.preference equals to 'dark'. The previously additional condition which checked whether the document.documentElement.className contains 'dark-mode' has been removed. This modification results in less computational complexity and could potentially improve performance.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 10, 2023
@roiLeo roiLeo mentioned this pull request Oct 10, 2023
Closed
hassnian
hassnian approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@hassnian hassnian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@roiLeo roiLeo merged commit ccfd8fe into nuxt Oct 10, 2023
10 of 11 checks passed
@roiLeo roiLeo deleted the fix/theme/isDarkMode branch October 10, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hassnian hassnian hassnian approved these changes

@daiagi daiagi Awaiting requested review from daiagi daiagi was automatically assigned from kodadot/code-review-guild

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 was automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dark/Light Mode toggle not working as expected
2 participants
@roiLeo @hassnian