Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 GalleryItem SEO #7575

Merged
merged 5 commits into from
Oct 10, 2023
Merged

🔧 GalleryItem SEO #7575

merged 5 commits into from
Oct 10, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 10, 2023

Tested on /ksm/gallery/16759320-8453d0ccb4cb7e9e59-A51-THE_FOUNDRY-00000246

Capture d’écran 2023-10-10 à 10 28 48 AM

@roiLeo roiLeo requested a review from a team as a code owner October 10, 2023 08:31
@roiLeo roiLeo requested review from daiagi and Jarsen136 and removed request for a team October 10, 2023 08:31
@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit dfddd39
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/65251dacad783200086b944f
😎 Deploy Preview https://deploy-preview-7575--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 10, 2023

AI-Generated Summary: This pull request introduces improvements to the Search Engine Optimization (SEO) of GalleryItem. The changes involve refactoring the meta computed property to seoDescription and seoCard computed properties, to better enhance SEO and readability. The pull request also adjusts useHead to useSeoMeta, with updates on the parameters passed to it for a more descriptive SEO meta data. Additionally, new console logs have been added to the generateNftImage function to aid in debugging. Changes are confined to two files: components/gallery/GalleryItem.vue and utils/seoImageGenerator.ts.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 10, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 10, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@roiLeo roiLeo requested a review from preschian October 10, 2023 08:40
@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 10, 2023

idk why but I can see the metadata in SeoMetaInspector

Capture d’écran 2023-10-10 à 10 41 13 AM

@preschian
Copy link
Member

idk why but I can see the metadata in SeoMetaInspector

it means we still need ssr-opengraph or prerender workers

Unless we found a way to enable ssr mode on our nuxt branch. https://nuxt.com/docs/api/composables/use-server-seo-meta

currently nuxt subdomain is served on netlify. I can't put ssr-opengraph or prerender on netlify

Screenshot 2023-10-10 161846

@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 10, 2023

it means we still need ssr-opengraph or prerender workers

Do we need to run a worker to fix this?

Unless we found a way to enable ssr mode on our nuxt branch. https://nuxt.com/docs/api/composables/use-server-seo-meta

We could try https://github.com/harlan-zw/nuxt-og-image & nuxt-seo-kit package

currently nuxt subdomain is served on netlify. I can't put ssr-opengraph or prerender on netlify

do you mean that it need to be on the same subdomain to generate image?

@preschian
Copy link
Member

Do we need to run a worker to fix this?

Unless we found a way to enable ssr mode on our nuxt branch. nuxt.com/docs/api/composables/use-server-seo-meta

We could try harlan-zw/nuxt-og-image & nuxt-seo-kit package

if we can enable SSR support in the nuxt branch, it's better to drop prerender workers. use that nuxt-og-image or nuxt-seo-kit instead

@yangwao
Copy link
Member

yangwao commented Oct 10, 2023

I would vote for nuxt-og-image as we can play with that easier

@roiLeo
Copy link
Contributor Author

roiLeo commented Oct 10, 2023

if we can enable SSR support in the nuxt branch, it's better to drop prerender workers. use that nuxt-og-image or nuxt-seo-kit instead

I'm pretty sure that if we enable ssr support now it will break many things (window & document need to be on client-side)

@preschian
Copy link
Member

if we can enable SSR support in the nuxt branch, it's better to drop prerender workers. use that nuxt-og-image or nuxt-seo-kit instead

I'm pretty sure that if we enable ssr support now it will break many things (window & document need to be on client-side)

yes 👍

I think if we want to start to check ssr mode, we can start from /blog first. In the meantime, we still use our prerender workers.

@roiLeo roiLeo merged commit c82b3e4 into kodadot:nuxt Oct 10, 2023
8 of 10 checks passed
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants