Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Chain redirect not working as expected for simple nft and collection creation #7579

Merged
merged 5 commits into from
Oct 10, 2023

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Oct 10, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI;

nft
CleanShot 2023-10-10 at 14 59 29

collection
CleanShot 2023-10-10 at 14 58 09

Copilot Summary

🤖 Generated by Copilot at ea20c0b

This pull request enhances the user experience of creating NFTs and collections on different blockchains. It fixes some UI issues with the URL and blockchain synchronization in CreateNft.vue and CreateCollection.vue, and prevents unwanted chain redirections in useChainRedirect.ts.

🤖 Generated by Copilot at ea20c0b

No chain can bind us, we create our own destiny
NO_REDIRECT_ROUTE_NAMES is the key to our liberty
We sync the URL and the blockchain with a watcher's eye
We unleash our NFTs and collections to the sky

@hassnian hassnian requested a review from a team as a code owner October 10, 2023 09:56
@hassnian hassnian requested review from floyd-li and Jarsen136 and removed request for a team October 10, 2023 09:56
@kodabot
Copy link
Collaborator

kodabot commented Oct 10, 2023

WARNING @hassnian PR for issue #7578 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #7578

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit fd98ba4
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/65252364b8ac500008cd1ccb
😎 Deploy Preview https://deploy-preview-7579--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 10, 2023

AI-Generated Summary: This pull request contains three patches. The first one adds missing 'create-nft' and 'create-collection' routes to the NO_REDIRECT_ROUTE_NAMES array in the useChainRedirect.ts file. The second patch resolves an issue in CreateNft.vue where the selected chain is not udated from the dropdown. This is achieved by watching the urlPrefix and updating the selectChain.value accordingly. It also fixes an issue where the setUrlPrefix was not updating correctly based on the current chain. The final patch resolves an issue in CreateCollection.vue where the collection was not updating chain changes from the navbar. This is achieved by watching urlPrefix and updating selectBlockchain.value when it changes. This patch also contains an update to the watch on currentChain to ensure setUrlPrefix is updated correctly.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 10, 2023
@hassnian hassnian changed the title fix: Chain redirect not working as expected for simple nft and collection fix: Chain redirect not working as expected for simple nft and collection creation Oct 10, 2023
Copy link
Contributor

@Jarsen136 Jarsen136 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve the code conflict.

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@yangwao
Copy link
Member

yangwao commented Oct 10, 2023

pay 30 usd

@yangwao yangwao merged commit 921261d into kodadot:nuxt Oct 10, 2023
12 checks passed
@yangwao
Copy link
Member

yangwao commented Oct 10, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 3.82 USD/DOT ~ 7.853 $DOT
🧗 13QUj3pZyFNfYj4AM336hRdyLQbevj5H3sR4PKmLEXLdwZhh
🔗 0xebcaa8a2a5b436f75c2d4293675937c380dd366c9f1a05d37277167e85fbd391

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 10, 2023
@hassnian hassnian deleted the nuxt/issue-0006 branch October 10, 2023 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chain redirect not working as expected for simple nft and collection
4 participants