fix: collection search no result #7581

newraina · 2023-10-10T11:34:42Z

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

Bugfix
Feature
Refactoring

Context

Ref Nuxt3 - Encountered problems list #7375 - search providing NFT results, but not collections
Requires deployment <snek/rubick/worker>

After fix:

CleanShot.2023-10-10-yOs3YhrI.mp4

Before submitting pull request, please make sure:

My contribution builds clean without any errors or warnings
I've merged recent default branch -- main and I've no conflicts
I've tried to respect high code quality standards
I've didn't break any original functionality

Optional

I've tested it at </ksm/collection>
I've tested PR on mobile
I've written unit tests 🧪
I've found edge cases

Did your issue had any of the "$" label on it?

Fill up your DOT address: Payout

Community participation

Are you at KodaDot Ecosystem Telegram?

Screenshot 📸

My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

`🤖 Generated by Copilot at 4d5199f`

Refactored search suggestion component to use Vue 3 refs for better reactivity. Fixed ref value access and modification in SearchSuggestion.vue.

`🤖 Generated by Copilot at 4d5199f`

To make search suggestions more snappy
The coder refactored some refs
But they had to be careful
Not to mess with the value
Or else the rendering would be messy

netlify · 2023-10-10T11:34:47Z

✅ Deploy Preview for nuxt-kodadot ready!

Name	Link
🔨 Latest commit	`4d5199f`
🔍 Latest deploy log	https://app.netlify.com/sites/nuxt-kodadot/deploys/652536d53a004b00087fed41
😎 Deploy Preview	https://deploy-preview-7581--nuxt-kodadot.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

reviewpad · 2023-10-10T11:34:57Z

Reviewpad Report

⚠️ Warnings

Please link an issue to the pull request

reviewpad · 2023-10-10T11:35:16Z

AI-Generated Summary: This pull request includes changes to the SearchSuggestion.vue component. The changes are primarily to the updateCollectionSuggestion function, where the collectionWithImagesList variable has been changed from a regular array to a reactive reference object using Vue's ref function. This results in updating the array mutation operation and the assignment to collectionResult.value to reflect this change. The intent behind these alterations seems to be to utilize Vue's reactivity system to better manage state within this function.