Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 deepscan #7586

Merged
merged 2 commits into from
Oct 10, 2023
Merged

🔧 deepscan #7586

merged 2 commits into from
Oct 10, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 10, 2023

  • fix deepscan
  • remove unused plugin

@roiLeo roiLeo requested a review from a team as a code owner October 10, 2023 12:44
@roiLeo roiLeo requested review from floyd-li and Jarsen136 and removed request for a team October 10, 2023 12:44
@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

✅ Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit 8b0ea41
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/65254716bd75c0000807599d
😎 Deploy Preview https://deploy-preview-7586--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Oct 10, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 10, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 10, 2023

AI-Generated Summary: This pull request includes two patches. The first patch involves changes in CookieBanner.vue, Buy.vue and NeoMessage.vue. In CookieBanner.vue, the order of the transition and div tags are switched. For Buy.vue, there's a refactoring in the onConfirm function to simplify the code. In NeoMessage.vue, the deprecated model object is deleted. The second patch removes an unused legacy plugin seoMetaGenerator.ts by deleting it and its reference in nuxt.config.js. Overall, these changes make the code cleaner and more efficient.

@roiLeo roiLeo requested a review from preschian October 10, 2023 12:44
@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@roiLeo roiLeo merged commit 64e73b6 into kodadot:nuxt Oct 10, 2023
12 checks passed
@roiLeo roiLeo deleted the fix/deepscan/lastbutnotleast branch October 10, 2023 12:49
@roiLeo roiLeo mentioned this pull request Oct 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@floyd-li floyd-li Awaiting requested review from floyd-li floyd-li was automatically assigned from kodadot/code-review-guild

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 was automatically assigned from kodadot/code-review-guild

@preschian preschian Awaiting requested review from preschian

Assignees
No one assigned
Labels
medium Pull request is medium waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roiLeo