Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔧 BasicImage placeholder #7588

Merged
merged 1 commit into from
Oct 10, 2023
Merged

🔧 BasicImage placeholder #7588

merged 1 commit into from
Oct 10, 2023

Conversation

roiLeo
Copy link
Contributor

@roiLeo roiLeo commented Oct 10, 2023

@roiLeo roiLeo requested a review from a team as a code owner October 10, 2023 14:12
@roiLeo roiLeo requested review from preschian and daiagi and removed request for a team October 10, 2023 14:12
@netlify
Copy link

netlify bot commented Oct 10, 2023 •
edited
Loading

✅ Deploy Preview for nuxt-kodadot ready!

Name Link
🔨 Latest commit c473420
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-kodadot/deploys/65255bb62d1ecf0007584f2d
😎 Deploy Preview https://deploy-preview-7588--nuxt-kodadot.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@roiLeo roiLeo merged commit e22bde7 into kodadot:nuxt Oct 10, 2023
5 of 7 checks passed
@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 10, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 10, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 10, 2023

AI-Generated Summary: This pull request includes modifications to two files: DropUpload.vue and BasicImage.vue. In DropUpload.vue, a transition animation named "fade" is added, which reveals an error message when a check fails. In BasicImage.vue, the conditions to display the image or the placeholder are modified. The image now displays if there exists some imageSrc, while the placeholder displays when the image has not loaded successfully yet. This increases overall user experience by providing a smooth transition and consistent placeholder image when loading images.

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@roiLeo roiLeo deleted the fix/BasicImage/Load branch October 10, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian Awaiting requested review from preschian preschian was automatically assigned from kodadot/code-review-guild

@daiagi daiagi Awaiting requested review from daiagi daiagi was automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roiLeo