Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cycling trough examples not working properly on drops #7598

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Oct 10, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖 Generated by Copilot at 2f10b81

Improved the functionality and code quality of the image slider component for unlockable collections. Refactored the component to use the useKeenSlider hook and the slider methods from keen-slider.

🤖 Generated by Copilot at 2f10b81

Oh we're the keenest crew on the web, me hearties
We use the useKeenSlider hook with ease
We simplify the code and we fix the bugs
And we navigate the slider as we please

@Jarsen136 Jarsen136 requested a review from a team as a code owner October 10, 2023 17:51
@Jarsen136 Jarsen136 requested review from preschian and roiLeo and removed request for a team October 10, 2023 17:51
@kodabot
Copy link
Collaborator

kodabot commented Oct 10, 2023

SUCCESS @Jarsen136 PR for issue #7593 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 10, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2f10b81
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65258f352870d90008073a87
😎 Deploy Preview https://deploy-preview-7598--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 10, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 10, 2023

Code Climate has analyzed commit 2f10b81 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 10, 2023

AI-Generated Summary: This pull request includes changes in the ImageSlider.vue component. The modifications handle issues in the cycling through examples on drops. The primary changes involve repurposing the previous implemented custom slider logic and instead leveraging built-in prev() and next() functions for navigation. The fixed bug transforms the click events on "arrow-left" and "arrow-right" to use these methods to navigate through the slides. In addition to this, it also changes the import statement for useKeenSlider from the ES module to the regular Vue module. The previously calculated sliderSettings have been removed in favor of this simpler approach. With these changes, the code becomes cleaner and easier to maintain.

@sonarcloud
Copy link

sonarcloud bot commented Oct 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 10, 2023
@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels Oct 11, 2023
@yangwao
Copy link
Member

yangwao commented Oct 11, 2023

pay 30 usd

@yangwao yangwao merged commit b6082bc into kodadot:main Oct 11, 2023
15 checks passed
@yangwao
Copy link
Member

yangwao commented Oct 11, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 3.78 USD/DOT ~ 7.937 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x3ed3c8c8dbc0a5673907df903dae61916eb1fe3da718d241661bead59a68c276

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 11, 2023
This was referenced Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cycling trough examples not working properly on drops
5 participants