Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Showing wrong number of items in collection #7603

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix: Showing wrong number of items in collection #7603

merged 1 commit into from
Oct 11, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Oct 11, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at d97764c

Filter out burned nfts from collection list query. This improves the accuracy and usability of the collectionListWithSearch.graphql query by excluding nfts that are no longer valid.

🤖 Generated by Copilot at d97764c

nfts in collection
filter out the ones burned_eq
autumn leaves falling

@Jarsen136 Jarsen136 requested a review from a team as a code owner October 11, 2023 05:54
@Jarsen136 Jarsen136 requested review from roiLeo and floyd-li and removed request for a team October 11, 2023 05:54
@netlify
Copy link

netlify bot commented Oct 11, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d97764c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65263887e7eecb000736af4b
😎 Deploy Preview https://deploy-preview-7603--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Oct 11, 2023

SUCCESS @Jarsen136 PR for issue #7600 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 11, 2023

AI-Generated Summary: This pull request involves an important bug fix targeting the file collectionListWithSearch.graphql. The modification ensures that the number of items shown in a collection is accurate by considering only those items that are not burned (where burned_eq is false). Thus, ensuring that the count or list of Non-Fungible Tokens (NFTs) in a collection is precise.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 11, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 11, 2023

Code Climate has analyzed commit d97764c and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

roiLeo
roiLeo approved these changes Oct 11, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code lgtm

@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels Oct 11, 2023
@yangwao
Copy link
Member

yangwao commented Oct 11, 2023

pay 20 usd

@yangwao yangwao merged commit 86d270c into kodadot:main Oct 11, 2023
15 checks passed
@yangwao
Copy link
Member

yangwao commented Oct 11, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 3.78 USD/DOT ~ 5.291 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xda500beeff833711b5b5fb7d37a6a7a41e185c8fb4a30eae95002ccda1d2db79

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 11, 2023
This was referenced Oct 11, 2023
Merged
Merged
@yangwao yangwao removed the paid pull-request has been paid label Oct 16, 2023
@yangwao
Copy link
Member

yangwao commented Oct 16, 2023

pay 20 usd

1 similar comment
@yangwao
Copy link
Member

yangwao commented Oct 16, 2023

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Oct 16, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 3.78 USD/DOT ~ 5.291 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x5da593821dc59cbe4edb7c189b82a869905928c7aa0ab99434ac929ac2182364

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 16, 2023
This was referenced Oct 16, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@floyd-li floyd-li Awaiting requested review from floyd-li floyd-li is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved small Pull request is small
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Showing wrong number of items in collection
4 participants
@Jarsen136 @kodabot @yangwao @roiLeo