Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: More tests and some tweaks #7721

Merged
merged 8 commits into from
Oct 18, 2023
Merged

Conversation

prury
Copy link
Member

@prury prury commented Oct 17, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Test

Context

Copilot Summary

🤖 Generated by Copilot at 8e02c3b

This pull request enhances the end-to-end testing of the NFT gallery by adding or updating data-testid attributes to various components and elements. It also adds new test files and commands for testing the profile, settings, and sidebar features. It also updates some existing test files to reflect the changes in the components and to add a new test for the RMRK2 NFT URL.

🤖 Generated by Copilot at 8e02c3b

To test the UI with more ease
We added data-testids
To modals and buttons and rows
And links and popovers that show
And wrote some new tests for these

@prury prury requested a review from a team as a code owner October 17, 2023 23:16
@prury prury requested review from preschian and floyd-li and removed request for a team October 17, 2023 23:16
@netlify
Copy link

netlify bot commented Oct 17, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit ec0464a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/652f2db471ef4200086f9871
😎 Deploy Preview https://deploy-preview-7721--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@prury prury requested a review from roiLeo October 17, 2023 23:16
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 17, 2023

AI-Generated Summary: This pull request includes 6 patches that mainly add data-testid attributes to various components to facilitate testing. This includes components like CookieBanner, Navbar, WalletAssetMenu, NotificationBoxModal, ShoppingCartModal, IdentityPopover, and ProfileDetail. Additionally, minor modifications are made to test files to accommodate the new test id's. Also, new test scenarios are added to the e2e test suites. Overall, these changes aim to enhance the testability of the code by providing unique IDs for key components and updating the existing test cases accordingly.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Oct 17, 2023
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 17, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

@codeclimate
Copy link

codeclimate bot commented Oct 18, 2023

Code Climate has analyzed commit ec0464a and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Oct 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Oct 18, 2023
@yangwao yangwao merged commit 0dfd0e8 into kodadot:main Oct 18, 2023
14 checks passed
This was referenced Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants