Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#7837 search bar updates #7842

Merged
merged 1 commit into from
Oct 28, 2023
Merged

#7837 search bar updates #7842

merged 1 commit into from
Oct 28, 2023

Conversation

prachi00
Copy link
Member

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
Screen Shot 2023-10-26 at 8 20 43 PM

Copilot Summary

@prachi00 prachi00 requested a review from a team as a code owner October 27, 2023 03:21
@prachi00 prachi00 requested review from preschian and Jarsen136 and removed request for a team October 27, 2023 03:21
@netlify
Copy link

netlify bot commented Oct 27, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c24908a
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/653b2cd9162460000846a879
😎 Deploy Preview https://deploy-preview-7842--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Oct 27, 2023

SUCCESS @prachi00 PR for issue #7837 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 27, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 27, 2023

Code Climate has analyzed commit c24908a and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 27, 2023

AI-Generated Summary: This pull request contains updates to the search bar functionality in the main navigation. Changes were made to assets/styles/layouts/_main-navigation.scss and components/Navbar.vue. In the SCSS file, a max-width property was added to enhance the search bar layout. In Navbar.vue, additional CSS classes were added to the navbar-item containing the search bar to ensure that its content is centered and more responsive. The enhancements aim to improve the search bar's usability and appearance in both mobile and desktop environments.

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@exezbcz
Copy link
Member

exezbcz commented Oct 27, 2023

thanks!

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 27, 2023
@yangwao
Copy link
Member

yangwao commented Oct 28, 2023

thanks!
pay 20 usd

@yangwao yangwao merged commit 880e517 into kodadot:main Oct 28, 2023
14 checks passed
@yangwao
Copy link
Member

yangwao commented Oct 28, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.16 USD/DOT ~ 4.808 $DOT
🧗 13Qx65nLd6SwdtjrRyuoEtp9CKXhF651xdHBPaXcvhwKm4N1
🔗 0xb21169ad209323cfbdd31207698252b9601bce620e611390df9bbf57ab1ac55b

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 28, 2023
This was referenced Oct 29, 2023
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian Awaiting requested review from preschian preschian is a code owner automatically assigned from kodadot/code-review-guild

@Jarsen136 Jarsen136 Awaiting requested review from Jarsen136 Jarsen136 is a code owner automatically assigned from kodadot/code-review-guild

Assignees
No one assigned
Labels
paid pull-request has been paid S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Search bar max width navbar
5 participants
@prachi00 @kodabot @exezbcz @yangwao @prury