Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Chart and holders - Collection Activity #7859

Merged
merged 6 commits into from
Oct 30, 2023
Merged

Align Chart and holders - Collection Activity #7859

merged 6 commits into from
Oct 30, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Oct 28, 2023 •
edited by ghost
Loading

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Context

Screenshot 📸

  • My fix has changed UI

image

Copilot Summary

🤖 Generated by Copilot at 1e2694d

Fixed tooltip alignment in price chart component. Removed top property from .price-chart__tooltip in _price-chart.scss.

🤖 Generated by Copilot at 1e2694d

top property gone
tooltip aligns with chart
a winter bug fixed

@daiagi daiagi requested a review from a team as a code owner October 28, 2023 02:14
@daiagi daiagi requested review from roiLeo and floyd-li and removed request for a team October 28, 2023 02:14
@netlify
Copy link

netlify bot commented Oct 28, 2023 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4882988
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/653f74e7c155a10008dbb72e
😎 Deploy Preview https://deploy-preview-7859--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Oct 28, 2023

SUCCESS @daiagi PR for issue #7853 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 28, 2023
@daiagi daiagi requested review from Jarsen136 and removed request for floyd-li October 28, 2023 02:14
@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 28, 2023

AI-Generated Summary: This pull request involves a minor change in the styles of the price chart component. Specifically, it removes a property (top: -8px;) from the _price-chart.scss file. Implications or effects of this change would depend on the layout and design of the web page where the component is used.

@daiagi daiagi enabled auto-merge October 28, 2023 02:14
@exezbcz
Copy link
Member

exezbcz commented Oct 28, 2023

yes, looks cool, but now the divider is right on the button
image

@yangwao
Copy link
Member

yangwao commented Oct 28, 2023

now the divider is right on the button

true

image

yet dropdown seems bit off? I know even in older version was

image

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Oct 28, 2023
@daiagi daiagi changed the title Update _price-chart.scss Align Chart and holders - Collection Activity Oct 30, 2023
@daiagi daiagi requested a review from exezbcz October 30, 2023 01:09
roiLeo
roiLeo reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks worse

Better solution would be to change aboslute position on dropdown

components/collection/activity/Activity.vue Outdated Show resolved Hide resolved
@codeclimate
Copy link

codeclimate bot commented Oct 30, 2023

Code Climate has analyzed commit 4882988 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Oct 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@daiagi daiagi added this pull request to the merge queue Oct 30, 2023
Merged via the queue into main with commit 80924c3 Oct 30, 2023
13 of 14 checks passed
@daiagi daiagi deleted the Align-chart-and-holders-section-in-one-line branch October 30, 2023 09:24
This was referenced Nov 1, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roiLeo roiLeo roiLeo approved these changes

@Jarsen136 Jarsen136 Jarsen136 approved these changes

@exezbcz exezbcz Awaiting requested review from exezbcz

Assignees
No one assigned
Labels
S-changes-requested-🤞 PR is almost good to go, just some fine tunning small Pull request is small waiting-for-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Align chart and holders section in one line?
7 participants
@daiagi @kodabot @exezbcz @yangwao @roiLeo @Jarsen136 @prury