Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: fixed container width on super wide screen #7861

Merged
merged 1 commit into from
Oct 29, 2023
Merged

Conversation

newraina
Copy link
Member

@newraina newraina commented Oct 28, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

The container width of the gallery item is fixed to 1344px when the screen width exceeds 1440px.

CleanShot 2023-10-28-Kh582O9P@2x

Copilot Summary

🤖 Generated by Copilot at 2b8ace8

This pull request introduces a new layout component gallery-item-layout.vue that is used for displaying gallery items (NFTs) and their collections with a consistent UI and SEO features. The pull request also applies this layout to the existing pages that show the details and the gallery of NFTs based on their prefix and id.

🤖 Generated by Copilot at 2b8ace8

gallery-item-layout
A new component for NFTs
With navbar and footer

@newraina newraina requested a review from a team as a code owner October 28, 2023 08:42
@newraina newraina requested review from roiLeo and Jarsen136 and removed request for a team October 28, 2023 08:42
@netlify
Copy link

netlify bot commented Oct 28, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2b8ace8
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/653cc98e57890d000824e854
😎 Deploy Preview https://deploy-preview-7861--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Oct 28, 2023

SUCCESS @newraina PR for issue #7703 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 28, 2023

AI-Generated Summary: This pull request introduces a new layout for gallery items on super wide screens. layouts/gallery-item-layout.vue is a newly created file that contains the HTML structure and associated Vue scripts for the layout. The container width for this layout is dynamic, it is fluid only when the screen width is less than 1440px. NuxtPage and Error components are also included in this layout to handle different scenarios. This layout is then used in the detail and gallery routes, which are present in the pages/[prefix]/detail/[id].vue and pages/[prefix]/gallery/[id].vue files respectively. These files are updated to utilize the gallery-item-layout thus providing a consistent user interface across pages.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 28, 2023
@codeclimate
Copy link

codeclimate bot commented Oct 28, 2023

Code Climate has analyzed commit 2b8ace8 and detected 0 issues on this pull request.

View more on Code Climate.

@sonarcloud
Copy link

sonarcloud bot commented Oct 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 28, 2023
@exezbcz
Copy link
Member

exezbcz commented Oct 28, 2023

nice job, thank you.

I am now thinking whether move the breakpoint to the 1920px

what do you think guys?

@newraina
Copy link
Member Author

newraina commented Oct 28, 2023

I am now thinking whether move the breakpoint to the 1920px

@exezbcz OK for me, easy to change.

It's true that 1440 isn't very wide.

@yangwao
Copy link
Member

yangwao commented Oct 29, 2023

I am now thinking whether move the breakpoint to the 1920px

let's stick now with 1440p and let see

@yangwao
Copy link
Member

yangwao commented Oct 29, 2023

Thanks!
pay 30 usd

@yangwao yangwao merged commit f5d4d30 into kodadot:main Oct 29, 2023
15 checks passed
@yangwao
Copy link
Member

yangwao commented Oct 29, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.21 USD/DOT ~ 7.126 $DOT
🧗 1CAv6Zq3yVxL3eKhC94GWTWVwp1w4jZbqeZ6wXx1rPAhrce
🔗 0x7b0a943e0aff426f2796507d1e3e22ff6cecb1a4d6fb5a6ed8032d65e9b4a6c5

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Oct 29, 2023
This was referenced Oct 29, 2023
@newraina newraina deleted the 7703 branch October 30, 2023 00:26
This was referenced Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove full width and back to fix width 1280px on gallery item?
5 participants