Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: subscribe form missing on route navigation #7886

Merged
merged 3 commits into from
Nov 1, 2023

Conversation

thnaylor
Copy link
Contributor

@thnaylor thnaylor commented Oct 30, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

Comments

  • Seems to be an issue when loading a script from useHead in a component when using nuxt internal navigation and the component gets remounted a second time.
  • Substackapi script also expects a div with id 'custom-substack-embed' to exist so loading the script globally/premounted causes errors.

Copilot Summary

🤖 Generated by Copilot at dfd2ead

Improved substack script loading in CustomSubstackEmbed component. The component now creates and removes the script element on mount and unmount instead of using useHead.

🤖 Generated by Copilot at dfd2ead

CustomSubstackEmbed
Loads script on mount, unmount
Snowflakes melt away

@thnaylor thnaylor requested a review from a team as a code owner October 30, 2023 09:19
@thnaylor thnaylor requested review from roiLeo and Jarsen136 and removed request for a team October 30, 2023 09:19
@kodabot
Copy link
Collaborator

kodabot commented Oct 30, 2023

SUCCESS @thnaylor PR for issue #7724 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@netlify
Copy link

netlify bot commented Oct 30, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit b4e7f5e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/654101dfd235e20008d7dab3
😎 Deploy Preview https://deploy-preview-7886--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad
Copy link
Contributor

reviewpad bot commented Oct 30, 2023

AI-Generated Summary: This pull request includes two patches from user tnaylor. The first patch fixes an issue where the subscribe form was missing on route navigation in the file CustomSubstackEmbed.vue. This was done by refactoring the script usage and creating the substackScript at runtime, along with appending it to the document head on component mounting and removing on unmount.

The second patch is a cleanup effort, removing an unused line of code where an id was being assigned to the substackScript within the onMounted method in the same file. These changes collectively enhance the robustness and cleanliness of the code.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Oct 30, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already fixed in #7725

@roiLeo roiLeo added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Oct 30, 2023
@thnaylor
Copy link
Contributor Author

@roiLeo Oh nice! Testing out SSR!

I guess if the ETA for #7725 is indeterminate we could use this in the mean time or close it. 👍

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Oct 30, 2023
@prury
Copy link
Member

prury commented Oct 31, 2023

please update PR @thnaylor

Copy link

codeclimate bot commented Oct 31, 2023

Code Climate has analyzed commit b4e7f5e and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.1% 1.1% Duplication

@yangwao
Copy link
Member

yangwao commented Nov 1, 2023

thanks!
pay 20 usd

@yangwao yangwao merged commit c332601 into kodadot:main Nov 1, 2023
14 checks passed
@yangwao
Copy link
Member

yangwao commented Nov 1, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.34 USD/DOT ~ 4.608 $DOT
🧗 123PCJXhjb15i6JwVVRGd7KvN2sSNZrtPjr5doJq9oWctoTt
🔗 0x1c0e3340a5aea188c98a878efc03544e1cdd2eb93800e530fcb7a39ffc510c67

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added paid pull-request has been paid and removed paid pull-request has been paid labels Nov 1, 2023
@yangwao
Copy link
Member

yangwao commented Nov 1, 2023

pay 20 usd

@yangwao
Copy link
Member

yangwao commented Nov 1, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 4.34 USD/DOT ~ 4.608 $DOT
🧗 123PCJXhjb15i6JwVVRGd7KvN2sSNZrtPjr5doJq9oWctoTt
🔗 0x7b04d937aed19b8f27d3b96fe552aa33fe70e80f583142b4cd8cdfe502ab38ba

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 1, 2023
This was referenced Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing email signup input field in footer
5 participants