Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove "beta" from Chain selection menu options + reorder #7915

Merged
merged 1 commit into from
Nov 1, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Nov 1, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖 Generated by Copilot at 5a13671

Updated chain names and prefixes in the UI and the tests. Removed [Beta] suffix from ahk and ahp chains and reordered chain prefixes in chains.ts to match the UI.

🤖 Generated by Copilot at 5a13671

chain-prefix order
aligned with UI names
a clear improvement

@Jarsen136 Jarsen136 requested a review from a team as a code owner November 1, 2023 13:59
@Jarsen136 Jarsen136 requested review from roiLeo and daiagi and removed request for a team November 1, 2023 13:59
Copy link

netlify bot commented Nov 1, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5a13671
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/654259cb4592fa00084c8841
😎 Deploy Preview https://deploy-preview-7915--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Nov 1, 2023

SUCCESS @Jarsen136 PR for issue #7911 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link
Contributor

reviewpad bot commented Nov 1, 2023

AI-Generated Summary: This pull request includes a minor adjustment to the chain selection menu options in the codebase. The label 'Beta' has been removed from two options, 'KusamaHub' and 'PolkadotHub' to reflect their transition out of the beta stage. The order of the chain prefixes has also been rearranged. Corresponding changes have been made in the end-to-end tests to ensure consistency. There is no addition or removal of functionalities, just modifications of the existing ones. The changes impact three files: 'chains.ts', 'names.ts', and 'createcollection.spec.ts'. No new dependencies have been introduced with this patch.

Copy link

codeclimate bot commented Nov 1, 2023

Code Climate has analyzed commit 5a13671 and detected 0 issues on this pull request.

View more on Code Climate.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Nov 1, 2023
Copy link

sonarcloud bot commented Nov 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.0% 1.0% Duplication

@prury
Copy link
Member

prury commented Nov 1, 2023

thank you for changing the test

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Nov 1, 2023
@yangwao
Copy link
Member

yangwao commented Nov 1, 2023

Thanks!
pay 30 usd

@yangwao yangwao merged commit 6299e71 into kodadot:main Nov 1, 2023
15 checks passed
@yangwao
Copy link
Member

yangwao commented Nov 1, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 4.4 USD/DOT ~ 6.818 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x7fc83e81c35272eb6f4975362caa3460ef236615fed8760043c83f29039d0e2d

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 1, 2023
This was referenced Nov 1, 2023
This was referenced Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "beta" from Chain selection menu options + reorder
6 participants