Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new mobile landing page #7922

Merged
merged 19 commits into from
Nov 6, 2023
Merged

new mobile landing page #7922

merged 19 commits into from
Nov 6, 2023

Conversation

newraina
Copy link
Member

@newraina newraina commented Nov 2, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

CleanShot 2023-11-02-XpYGFmoK@2x

Copilot Summary

🤖 Generated by Copilot at 2632727

This pull request improves the responsiveness and user experience of the landing page and the navigation bar for mobile devices. It introduces a new component MobileLanding.vue that displays a custom layout with a chain selection option and a banner for a free generative drop. It also refactors the existing LandingPage.vue component to use different components for mobile and desktop layouts. It adds new computed properties and constants to handle the chain logic and icons. It updates the localization keys and the styles for the landing page components.

🤖 Generated by Copilot at 2632727

We're the masters of the chain, we choose our destiny
We unlock the secrets of the generative drop
We defy the limits of the screen, we adapt to any size
We optimize the performance of the landing page

@newraina newraina requested a review from a team as a code owner November 2, 2023 01:48
@newraina newraina requested review from roiLeo and daiagi and removed request for a team November 2, 2023 01:48
Copy link

netlify bot commented Nov 2, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 47c1470
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65476dd4bf099b0008930afa
😎 Deploy Preview https://deploy-preview-7922--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Nov 2, 2023

SUCCESS @newraina PR for issue #7896 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link
Contributor

reviewpad bot commented Nov 2, 2023

AI-Generated Summary: This pull request includes four different updates. Firstly, changes have been made to the Navbar.vue component to always show the search entry on mobile. An additional isTinyMobile computed property has been implemented to adjust the interface for smaller mobile screens. Secondly, the unlockable landing tag icon was moved to a separate SVG file to simplify the Vue component and enhance maintainability. Next, a new mobile landing page was created with new components and additions to several files including one for mobile banner and one for mobile landing itself with related styling and localization. Lastly, it removes unused 'section-search' CSS class to reduce code clutter, improve readability, and optimize the CSS file size.

@reviewpad reviewpad bot added medium Pull request is medium waiting-for-review labels Nov 2, 2023
@newraina newraina changed the title always show search entry on mobile new mobile landing page Nov 2, 2023
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small stuff

components/landing/LandingPage.vue Outdated Show resolved Hide resolved
components/Navbar.vue Outdated Show resolved Hide resolved
components/landing/MobileLanding.vue Outdated Show resolved Hide resolved
locales/en.json Outdated Show resolved Hide resolved
@exezbcz
Copy link
Member

exezbcz commented Nov 2, 2023

visual oki, like it, thanks!

@prury
Copy link
Member

prury commented Nov 2, 2023

here form me it still shows all the networks, and the Claim Yours button redirects to the wrong drop(should redirect to generative drop)

image

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Nov 2, 2023
@exezbcz
Copy link
Member

exezbcz commented Nov 2, 2023

here form me it still shows all the networks

yeah, saw that too, could you please make sure that on production (kodadot.xyz) it will show only the few networks

@newraina
Copy link
Member Author

newraina commented Nov 3, 2023

@prury @exezbcz

it still shows all the networks

I've limited it so that only popularChains (ksm / ahk / ahp) will show up in the production environment. Do you guys think we should only display these three in any environment?

const chains = computed(() => {
  if (isProduction) {
    return availableChainsWithIcon.value.filter((c) =>
      popularChains.includes(String(c.value)),
    )
  }
  return availableChainsWithIcon.value
})

the Claim Yours button redirects to the wrong drop(should redirect to generative drop)

fixed.

@prury
Copy link
Member

prury commented Nov 3, 2023

@prury @exezbcz

it still shows all the networks

I've limited it so that only popularChains (ksm / ahk / ahp) will show up in the production environment. Do you guys think we should only display these three in any environment?

nope, you did the right thing, mb and thank you

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed S-changes-requested-🤞 PR is almost good to go, just some fine tunning labels Nov 3, 2023
@roiLeo roiLeo added S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved and removed waiting-for-review labels Nov 3, 2023
Copy link
Contributor

@daiagi daiagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor suggestions,
overall lgtm

components/landing/MobileHeroBanner.vue Outdated Show resolved Hide resolved
components/landing/MobileHeroBanner.vue Outdated Show resolved Hide resolved
composables/useChain.ts Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Nov 5, 2023

Code Climate has analyzed commit 47c1470 and detected 2 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@yangwao
Copy link
Member

yangwao commented Nov 6, 2023

Thanks!
pay 50 usd

@yangwao yangwao merged commit 25f4fb2 into kodadot:main Nov 6, 2023
13 of 14 checks passed
@yangwao
Copy link
Member

yangwao commented Nov 6, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 4.86 USD/DOT ~ 10.288 $DOT
🧗 1CAv6Zq3yVxL3eKhC94GWTWVwp1w4jZbqeZ6wXx1rPAhrce
🔗 0xebe5815342366560918c0608be13fd9aec9cecab3eeea2bc362775a8d8bcd945

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 6, 2023
@newraina newraina deleted the 7896 branch November 7, 2023 00:36
This was referenced Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile landing improvements
8 participants