-
-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new mobile landing page #7922
new mobile landing page #7922
Conversation
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AI-Generated Summary: This pull request includes four different updates. Firstly, changes have been made to the Navbar.vue component to always show the search entry on mobile. An additional isTinyMobile computed property has been implemented to adjust the interface for smaller mobile screens. Secondly, the unlockable landing tag icon was moved to a separate SVG file to simplify the Vue component and enhance maintainability. Next, a new mobile landing page was created with new components and additions to several files including one for mobile banner and one for mobile landing itself with related styling and localization. Lastly, it removes unused 'section-search' CSS class to reduce code clutter, improve readability, and optimize the CSS file size. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small stuff
components/collection/unlockable/UnlockableLandingMobileBanner.vue
Outdated
Show resolved
Hide resolved
visual oki, like it, thanks! |
yeah, saw that too, could you please make sure that on production (kodadot.xyz) it will show only the few networks |
I've limited it so that only popularChains (ksm / ahk / ahp) will show up in the production environment. Do you guys think we should only display these three in any environment? const chains = computed(() => {
if (isProduction) {
return availableChainsWithIcon.value.filter((c) =>
popularChains.includes(String(c.value)),
)
}
return availableChainsWithIcon.value
})
fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor suggestions,
overall lgtm
Code Climate has analyzed commit 47c1470 and detected 2 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Thanks! |
😍 Perfect, I’ve sent the payout 🪅 Let’s grab another issue and get rewarded! |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
Before submitting pull request, please make sure:
Optional
Did your issue had any of the "$" label on it?
Community participation
Screenshot 📸
Copilot Summary
🤖 Generated by Copilot at 2632727
This pull request improves the responsiveness and user experience of the landing page and the navigation bar for mobile devices. It introduces a new component
MobileLanding.vue
that displays a custom layout with a chain selection option and a banner for a free generative drop. It also refactors the existingLandingPage.vue
component to use different components for mobile and desktop layouts. It adds new computed properties and constants to handle the chain logic and icons. It updates the localization keys and the styles for the landing page components.🤖 Generated by Copilot at 2632727