Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove not enough balance disabled status #7968

Merged
merged 2 commits into from
Nov 9, 2023
Merged

Conversation

newraina
Copy link
Member

@newraina newraina commented Nov 8, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Now, even if the balance is insufficient, the Buy button will be active.
CleanShot 2023-11-08-4yOStO6p@2x

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

Copilot Summary

🤖 Generated by Copilot at 63026c4

Refactored the GalleryItemBuy component to use a single hook and property for buying NFTs. Removed unused code and simplified the UI logic.

🤖 Generated by Copilot at 63026c4

The GalleryItemBuy component
Was cluttered and needed improvement
So they cut out the fluff
And left just enough
To use nft.price and useShoppingCartStore hook content

@newraina newraina requested a review from a team as a code owner November 8, 2023 12:05
@newraina newraina requested review from preschian and floyd-li and removed request for a team November 8, 2023 12:05
@kodabot
Copy link
Collaborator

kodabot commented Nov 8, 2023

SUCCESS @newraina PR for issue #7880 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Nov 8, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 2acab53
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/654c8dc126dd50000835a88b
😎 Deploy Preview https://deploy-preview-7968--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Nov 8, 2023

AI-Generated Summary: This pull request adds a significant change to the GalleryItemBuy.vue component in the gallery. It mainly involves the removal of the tooltip that displays the message "notEnoughBalanceChain" when a user does not have enough balance to buy an item. The changes include the following:

  • The NeoTooltip component along with its content block and disabled prop used for showing tooltips have been removed. The NeoButton component that was inside the tooltip has been moved out to replace the tooltip.
  • Several script lines related to the disabled state of the button (addFunds, balance, disabled), unused imports like NeoTooltip and getKusamaAssetId were also deleted.
  • The effect of these changes leads to a button that no longer disables when the balance is not sufficient, and no tooltips appear to indicate the low balance.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Nov 8, 2023
@prury prury requested review from roiLeo and removed request for floyd-li November 8, 2023 19:25
@exezbcz
Copy link
Member

exezbcz commented Nov 8, 2023

nice, thanks!

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Nov 8, 2023
Copy link

codeclimate bot commented Nov 9, 2023

Code Climate has analyzed commit 2acab53 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.8% 0.8% Duplication

@yangwao
Copy link
Member

yangwao commented Nov 9, 2023

Thanks!
pay 30 usd

@yangwao yangwao merged commit ad93267 into kodadot:main Nov 9, 2023
15 checks passed
@yangwao
Copy link
Member

yangwao commented Nov 9, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 5.1 USD/DOT ~ 5.882 $DOT
🧗 1CAv6Zq3yVxL3eKhC94GWTWVwp1w4jZbqeZ6wXx1rPAhrce
🔗 0x14fedd769bc455f2d745b3b3598f6a5f35eca785cfcf022d39ebe437b2ed5f0c

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 9, 2023
This was referenced Nov 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change disabled to active
6 participants