Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable video controls on explore cards #8055

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

hassnian
Copy link
Contributor

@hassnian hassnian commented Nov 14, 2023

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI;

CleanShot 2023-11-14 at 13 32 12

Copilot Summary

🤖 Generated by Copilot at 7549d0c

This pull request adds a new prop hideVideoControls to several components related to NFT media previews. This prop allows hiding the video controls for NFT videos, improving the user experience and the gallery design.

🤖 Generated by Copilot at 7549d0c

Oh we are the coders of the NFT sea
And we like to make our previews tidy
We added a prop to hideVideoControls
So pull up the sail and let the wind roll

@hassnian hassnian requested a review from a team as a code owner November 14, 2023 08:31
@hassnian hassnian requested review from preschian and roiLeo and removed request for a team November 14, 2023 08:31
@kodabot
Copy link
Collaborator

kodabot commented Nov 14, 2023

SUCCESS @hassnian PR for issue #8022 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit c014a19
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65533f1146eb7e000828b5fa
😎 Deploy Preview https://deploy-preview-8055--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Nov 14, 2023

AI-Generated Summary: This pull request applies a patch that focuses on disabling video controls in the explore page of a web application. It affects four Vue files within the ItemsGrid and NeoNftCard components. The main change includes the addition of the 'hideVideoControls' attribute in various sections of these files. Additionally, it modifies the NeoNftCard.vue to take mediaHideVideoControls as a prop to handle the visibility of video controls.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Nov 14, 2023
Copy link
Member

@preschian preschian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link

codeclimate bot commented Nov 14, 2023

Code Climate has analyzed commit c014a19 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prury
Copy link
Member

prury commented Nov 14, 2023

If its intended that the only place we have video controls is inside gallery item, then it works
the only collection bugging me is this one: https://deploy-preview-8055--koda-canary.netlify.app/ahk/gallery/249-5 , but i guess its a problem with the collection itself and not with PR

I'm assembling a list of testing resources:
#7826 (comment)

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Nov 14, 2023
@yangwao
Copy link
Member

yangwao commented Nov 14, 2023

Thanks!
pay 30 usd

@yangwao yangwao merged commit f80d92f into kodadot:main Nov 14, 2023
15 of 16 checks passed
@yangwao
Copy link
Member

yangwao commented Nov 14, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 5.45 USD/DOT ~ 5.505 $DOT
🧗 13QUj3pZyFNfYj4AM336hRdyLQbevj5H3sR4PKmLEXLdwZhh
🔗 0x78d0abf138f41773b43be6ca5301699b4c8a74471f4fd8a46ab9bd213fc3a554

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 14, 2023
This was referenced Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable video controls on explore cards
6 participants