Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed onerror in NeoAvatar #8239

Merged
merged 2 commits into from
Nov 24, 2023

Conversation

shashkovdanil
Copy link
Contributor

@shashkovdanil shashkovdanil commented Nov 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ksm/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.
    Screenshot 2023-11-24 155145

Copilot Summary

🤖[deprecated] Generated by Copilot at fa0c730

Enhanced the robustness and performance of the NeoAvatar component by preventing repeated error events and unnecessary image requests.

🤖[deprecated] Generated by Copilot at fa0c730

NeoAvatar fails
gracefully handles errors
removes srcset - fall

@shashkovdanil shashkovdanil requested a review from a team as a code owner November 24, 2023 15:54
@shashkovdanil shashkovdanil requested review from daiagi and Jarsen136 and removed request for a team November 24, 2023 15:54
Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 5bceda3
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6560c77ca77c2a000972809a
😎 Deploy Preview https://deploy-preview-8239--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Nov 24, 2023

AI-Generated Summary: This pull request contains changes to the 'NeoAvatar.vue' component that ensure the 'onError' function is only triggered once if an error is detected. The programmer has also added a new line of code that removes the 'srcset' attribute from the target if the onError event handler is triggered. This fix primarily focuses on enhancing the performance and functionality of the 'NeoAvatar' component.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Nov 24, 2023
Copy link

codeclimate bot commented Nov 24, 2023

Code Climate has analyzed commit 5bceda3 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prury
Copy link
Member

prury commented Nov 24, 2023

cool
image
seems fixed on canary tho

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Nov 24, 2023
@yangwao
Copy link
Member

yangwao commented Nov 24, 2023

thanks!
pay 20 usd

@yangwao yangwao merged commit 0c3ed09 into kodadot:main Nov 24, 2023
17 checks passed
@yangwao
Copy link
Member

yangwao commented Nov 24, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 5.25 USD/DOT ~ 3.81 $DOT
🧗 16SpvdDgKNiQ3c53DxX7refnQcKUD3uRNim3Z1HBJLNGrtSP
🔗 0x312a05f4945778d93bcbcf43c69d429c345403778df6e339831fa53672cb75fd

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 24, 2023
This was referenced Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cyberpunk2077 at kodadot?
3 participants