Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/Opengraph #8241

Closed
wants to merge 4 commits into from
Closed

Test/Opengraph #8241

wants to merge 4 commits into from

Conversation

prury
Copy link
Member

@prury prury commented Nov 24, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Test

Context

Copilot Summary

🤖[deprecated] Generated by Copilot at 28c09fe

This pull request adds two new test files for checking the opengraph tags of collection and item pages. The tests use test fixtures and assert that the meta tags have the correct attributes and contents for social media sharing and SEO. The tests also delete an unused test file opengraph.ts.

🤖[deprecated] Generated by Copilot at 28c09fe

opengraph tags
testing collection, item
autumn leaves falling

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 09513da
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65611487ca4ad0000868727e
😎 Deploy Preview https://deploy-preview-8241--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Nov 24, 2023

AI-Generated Summary: This pull request contains three patches. The first patch provides a new end-to-end test for the 'opengraph collection', which verifies the metadata information in an opengraph collection against predefined data. The second patch creates a new end-to-end test for 'opengraph item', which checks the metadata of an opengraph item against test data. With these two patches, all metadata of both collections and items in an opengraph are tested to ensure they match the expected values. The third patch removes the old test 'opengraph.ts'. These changes should result in improved testing and maintenance of the code base.

@reviewpad reviewpad bot added the medium Pull request is medium label Nov 24, 2023
Copy link
Contributor

reviewpad bot commented Nov 24, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link

codeclimate bot commented Nov 24, 2023

Code Climate has analyzed commit 09513da and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
68.1% 68.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@prury prury marked this pull request as ready for review November 24, 2023 21:38
@prury prury requested a review from a team as a code owner November 24, 2023 21:38
@prury prury requested review from preschian and roiLeo and removed request for a team November 24, 2023 21:38
Copy link
Contributor

@roiLeo roiLeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh.. that what you asked me.
I don't think this need to be tested here since they are overwritten by our opengraph workers.

@prury
Copy link
Member Author

prury commented Nov 25, 2023

oh.. that what you asked me. I don't think this need to be tested here since they are overwritten by our opengraph workers.

allright, closing!

@prury prury closed this Nov 25, 2023
@prury prury deleted the test/opengraph branch November 28, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
medium Pull request is medium waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants