Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fallback nuxt image #8252

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Conversation

preschian
Copy link
Member

@preschian preschian commented Nov 26, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

Copilot Summary

🤖[deprecated] Generated by Copilot at 10d717e

Improved image loading and fallbacks in various components. Used ImageMedia component to handle different image sources and statuses in NeoAvatar and MediaItem. Added a default placeholder image for MediaItem.

🤖[deprecated] Generated by Copilot at 10d717e

No more blanks in the dark, we have placeholder
ImageMedia is our shield, it handles all the cases
We don't need TheImage, it was a weak illusion
We use NeoAvatar, it gives us more expression

Copy link

netlify bot commented Nov 26, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 10d717e
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6562d81fb1b5660008127d60
😎 Deploy Preview https://deploy-preview-8252--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

reviewpad bot commented Nov 26, 2023

AI-Generated Summary: This pull request fixes the fallback behaviour for images in Nuxt. It adds multiple error checks for loading images in the ImageMedia.vue by trying to load the normal image first, then the original URL if the normal one fails, and finally loading a placeholder image if both previous attempts fail. There were changes in the MediaItem.vue file to update the image's placeholder. Moreover, TheImage component is replaced by the ImageMedia component in NeoAvatar.vue, and the error handling for image loading was removed since it's handled in the new component. It also adds alt attributes to images for better accessibility. In summary, these changes aim to improve the reliability and accessibility of image loading in the application.

@reviewpad reviewpad bot added the small Pull request is small label Nov 26, 2023
Copy link
Contributor

reviewpad bot commented Nov 26, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link

sonarcloud bot commented Nov 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Nov 26, 2023

Code Climate has analyzed commit 10d717e and detected 0 issues on this pull request.

View more on Code Climate.

@preschian preschian marked this pull request as ready for review November 26, 2023 05:36
@preschian preschian requested a review from a team as a code owner November 26, 2023 05:36
@preschian preschian requested review from daiagi and Jarsen136 and removed request for a team November 26, 2023 05:36
@yangwao
Copy link
Member

yangwao commented Nov 27, 2023

thanks!
pay 20 usd

@yangwao yangwao merged commit 998f9b6 into main Nov 27, 2023
18 checks passed
@yangwao yangwao deleted the fix/fallback-nuxtimg-to-image-worker branch November 27, 2023 14:44
@yangwao
Copy link
Member

yangwao commented Nov 27, 2023

😍 Perfect, I’ve sent the payout
💵 $20 @ 5.11 USD/DOT ~ 3.914 $DOT
🧗 1xjvRADwdJcnmUCLWerEHR4iGCT5EBTm4D4fzLLg4LcAC9p
🔗 0xba6e4568bdbf1ccee9f8f12c76a92eac2cf48d97abea834d078bd52ca16fd681

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 27, 2023
This was referenced Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants