Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection-activity-toggle-hide-outliers #8253

Merged
merged 5 commits into from
Nov 28, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Nov 26, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI

image

Copilot Summary

🤖[deprecated] Generated by Copilot at 74bbdff

Added a feature to hide outliers in the price charts of NFT collections and the global market. Improved the UI and positioning of the dropdown components used to control the chart options. Refactored the NeoDropdown.vue component and updated the translation file.

🤖[deprecated] Generated by Copilot at 74bbdff

Sing, O Muse, of the skillful coder who refined the chart
Of the collection's price, with many a clever art.
He made a dropdown menu, NeoDropdown, shining bright,
And gave it a position prop, to place it left or right.

@daiagi daiagi requested a review from a team as a code owner November 26, 2023 07:17
@daiagi daiagi requested review from preschian and Jarsen136 and removed request for a team November 26, 2023 07:17
Copy link

netlify bot commented Nov 26, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 65ad5a1
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6564330efcf03e0008faed2f
😎 Deploy Preview https://deploy-preview-8253--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Nov 26, 2023

WARNING @daiagi PR for issue #8108 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #8108

@kodabot
Copy link
Collaborator

kodabot commented Nov 26, 2023

SUCCESS @daiagi PR for issue #8234 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Nov 26, 2023
Copy link
Contributor

reviewpad bot commented Nov 26, 2023

AI-Generated Summary: This pull request consists of two patches to the Vue.js codebase of the application.

The first patch modifies NeoDropdown.vue component and specifically fixes the position property of the o-drop__menu CSS class from this.autoPosition to this.position.

The second patch makes multiple changes. It changes the position of the dropdown menu in the _price-chart.scss and hides the outliers dropdown in the price chart. It achieves this by adding a new dropdown functionality in PriceChart.vue and making it possible to hide outliers via ActivityChart.vue. The latter change necessitates new localized text in en.json titled "Hide Outliers". Furthermore, this patch includes moving the time-range dropdown, CSS changes to position newly added elements, and additional logic to decide whether or not outliers should be visible based on the user's choice.

components/chart/PriceChart.vue Outdated Show resolved Hide resolved
@exezbcz
Copy link
Member

exezbcz commented Nov 26, 2023

the text to 12px font please

no hover over the button
image

  • the button is not clickable - only the checkbox is

would there be a sharper icon for settings? In fontawesome?

image

the default state color should be k-grey, now neutral-7

otherwise okay, thanks!

position="bottom-left">
<template #trigger>
<NeoButton no-shadow variant="icon">
<NeoIcon icon="gear" pack="fas" size="medium" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<NeoIcon icon="gear" pack="fas" size="medium" />
<NeoIcon icon="gear" size="medium" />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fimga:

image

without pack :
image

@daiagi
Copy link
Contributor Author

daiagi commented Nov 27, 2023

@exezbcz
all done.
please check again

Copy link

codeclimate bot commented Nov 27, 2023

Code Climate has analyzed commit 65ad5a1 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@daiagi daiagi mentioned this pull request Nov 27, 2023
5 tasks
@yangwao
Copy link
Member

yangwao commented Nov 28, 2023

does the job

image

@yangwao
Copy link
Member

yangwao commented Nov 28, 2023

Thanks!
pay 30 usd

@yangwao yangwao merged commit ccc0c3c into main Nov 28, 2023
16 of 17 checks passed
@yangwao yangwao deleted the collection-activity-toggle-hide-outliers branch November 28, 2023 12:43
@yangwao
Copy link
Member

yangwao commented Nov 28, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 5.19 USD/DOT ~ 5.78 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0x06038c33ef1abf29b3eb849ff7a261e83d4141e996332c79fb5a54976cb462cb

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 28, 2023
This was referenced Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid small Pull request is small waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide outliers toggle in chart settings List is not showing on chart but appears in activity
6 participants