Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LatestSales---show-sale-price #8257

Merged
merged 3 commits into from
Nov 27, 2023
Merged

LatestSales---show-sale-price #8257

merged 3 commits into from
Nov 27, 2023

Conversation

daiagi
Copy link
Contributor

@daiagi daiagi commented Nov 26, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Feature

Needs Design check

Context

Did your issue had any of the "$" label on it?

Yes $

Screenshot 📸

  • My fix has changed UI

Uploading image.png…

Copilot Summary

🤖[deprecated] Generated by Copilot at 665e723

This pull request adds a feature to display the latest sale price and a sold label for NFTs that have been sold recently in the CarouselInfo component. It also updates the GraphQL queries and the CarouselNFT interface to include the sale price data from the chain events.

🤖[deprecated] Generated by Copilot at 665e723

CarouselNFT shows
latest sale price from meta
autumn leaves fall fast

@daiagi daiagi requested a review from a team as a code owner November 26, 2023 12:43
@daiagi daiagi requested review from preschian and Jarsen136 and removed request for a team November 26, 2023 12:43
Copy link

netlify bot commented Nov 26, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 665e723
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/65633d814ab5c20009f6a92c
😎 Deploy Preview https://deploy-preview-8257--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Nov 26, 2023

SUCCESS @daiagi PR for issue #8109 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link
Contributor

reviewpad bot commented Nov 26, 2023

AI-Generated Summary: This pull request includes three patches which introduce several changes around the display of sales and prices in a NFT carousel module.

  1. The first patch adds a 'latestSalePrice' field to the CarouselNFT interface, implements its usage in CarouselInfo.vue, and adjusts related logic in useCarouselEvents.ts. It mirrors these changes in the accompanying GraphQL queries, for 'latestEvents' in both 'general' and 'ksm'.

  2. The second patch changes useCarouselEvents.ts to give a condition to whether it shows the 'sold' tag for an item in a carousel. If the 'withLastestSale' flag is set to false, sold items won't be displayed in the carousel.

  3. The third patch modifies the text displayed when an item in the carousel was sold. Instead of always showing "- Sold", it is now localized and can be customised via i18n. It also adds a new computed function to control when the 'sold' tag is shown. It will only be displayed when the 'latestSalePrice' field is larger than 0.

These patches improve customization for prices and sold status display in carousel according to different types of NFTs and user preferences.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Nov 26, 2023
Copy link

sonarcloud bot commented Nov 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link

codeclimate bot commented Nov 26, 2023

Code Climate has analyzed commit 665e723 and detected 0 issues on this pull request.

View more on Code Climate.

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed waiting-for-review labels Nov 27, 2023
@yangwao
Copy link
Member

yangwao commented Nov 27, 2023

Thanks!
pay 50 usd

@yangwao yangwao merged commit 3393302 into main Nov 27, 2023
16 of 17 checks passed
@yangwao yangwao deleted the latestSales---show-sale-price branch November 27, 2023 14:39
@yangwao
Copy link
Member

yangwao commented Nov 27, 2023

😍 Perfect, I’ve sent the payout
💵 $50 @ 5.12 USD/DOT ~ 9.766 $DOT
🧗 1cAsKZYNRb8dkSCpn4eVkEn6ycNZTGoDo5dGDgB8J1UUWK8
🔗 0xafc779c44c4a4a480210cfcbda176561ce05f6a0bc4b62d8e2727d2fed4dc5ab

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 27, 2023
This was referenced Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latest Sales UX on landing
7 participants