Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: floor price dose not load on profile page #8259

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

Jarsen136
Copy link
Contributor

@Jarsen136 Jarsen136 commented Nov 26, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs QA check

  • @kodadot/qa-guild please review

Context

(The issue related with width of modal was solved in another PR #8255)

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed UI
image

Copilot Summary

🤖[deprecated] Generated by Copilot at 8c9bd44

This pull request fixes the floor price calculation and display for different collections of nfts. It adds a fallback value of 0 for the floor price in ItemsGridImageTokenEntity.vue and filters out zero-priced nfts from the queries in nftListWithSearch.graphql files.

🤖[deprecated] Generated by Copilot at 8c9bd44

floorPrice query
filters out zero values
no more false floors - spring

@Jarsen136 Jarsen136 requested a review from a team as a code owner November 26, 2023 16:30
@Jarsen136 Jarsen136 requested review from roiLeo and daiagi and removed request for a team November 26, 2023 16:30
Copy link

netlify bot commented Nov 26, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 8c9bd44
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/656372c4c815a6000827faeb
😎 Deploy Preview https://deploy-preview-8259--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kodabot
Copy link
Collaborator

kodabot commented Nov 26, 2023

SUCCESS @Jarsen136 PR for issue #8245 which is assigned to you. Please wait for review and don't hesitate to grab another issue in the meantime!

Copy link
Contributor

reviewpad bot commented Nov 26, 2023

AI-Generated Summary: This pull request addresses an issue where the floor price was not loading correctly on the profile page. Changes were made across 5 files, primarily in a Vue component and four GraphQL query files. The Vue component saw a tweak to redefine the floor price, allowing a fallback to '0' if the original price is not available. The GraphQL queries, on the other hand, were updated to consider only non-burned NFTs with a price greater than '0' for floor price calculations. By limiting the numbers of NFTs considered, the updated queries improve the efficiency of data fetching and floor price calculation.

@reviewpad reviewpad bot added small Pull request is small waiting-for-review labels Nov 26, 2023
Copy link

codeclimate bot commented Nov 26, 2023

Code Climate has analyzed commit 8c9bd44 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Nov 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.9% 0.9% Duplication

@exezbcz
Copy link
Member

exezbcz commented Nov 26, 2023

works for me, thanks

@prury prury added S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked and removed waiting-for-review labels Nov 27, 2023
@yangwao
Copy link
Member

yangwao commented Nov 27, 2023

Thanks!
pay 30 usd

@yangwao yangwao merged commit b92b79d into kodadot:main Nov 27, 2023
16 of 17 checks passed
@yangwao
Copy link
Member

yangwao commented Nov 27, 2023

😍 Perfect, I’ve sent the payout
💵 $30 @ 5.12 USD/DOT ~ 5.859 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0x2b76904474bddb1ca983aa4a679c466ec3a209f05b8cccd0f1279e6df72514a1

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Nov 27, 2023
This was referenced Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-visual-ok-✅ S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked small Pull request is small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listing modal width and floor price
7 participants