Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/Remove old Cypress tests #8277

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Tests/Remove old Cypress tests #8277

merged 1 commit into from
Nov 27, 2023

Conversation

prury
Copy link
Member

@prury prury commented Nov 27, 2023

Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Deletion

Context

Copilot Summary

🤖[deprecated] Generated by Copilot at 75239b1

Removed deprecated cypress tests that were no longer used or maintained. These tests were replaced by newer ones in the tests/cypress folder.

🤖[deprecated] Generated by Copilot at 75239b1

is_valid checks
refactored for clarity
autumn leaves falling

@prury prury requested a review from a team as a code owner November 27, 2023 16:17
@prury prury requested review from daiagi and Jarsen136 and removed request for a team November 27, 2023 16:17
Copy link

netlify bot commented Nov 27, 2023

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 75239b1
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6564c108faf04e0008dcb245
😎 Deploy Preview https://deploy-preview-8277--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@reviewpad reviewpad bot added large Pull request is large waiting-for-review labels Nov 27, 2023
Copy link
Contributor

reviewpad bot commented Nov 27, 2023

Reviewpad Report

⚠️ Warnings

  • Please link an issue to the pull request

Copy link

sonarcloud bot commented Nov 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link

codeclimate bot commented Nov 27, 2023

Code Climate has analyzed commit 75239b1 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link
Contributor

reviewpad bot commented Nov 27, 2023

AI-Generated Summary: This pull request primarily involves the deletion of various files within the tests/cypress-deprecated/ directory of the codebase. These deletions impact numerous previously run tests, which engage with different aspects of the system's functionality. Test file media.cy.ts, for example, which evaluated the rendering of different media types, has been removed, as well as commands.ts.old, basicE2E.cy.ts, and prefix.cy.ts, each of which contained various tests and commands.

Further files removed include e2e.ts, redirect.cy.ts, language.cy.ts, identity.cy.ts, opengraph-item.cy.ts, create-collection.cy.ts, e2e-run-tests.js, rmrk-simple-mint.cy.ts, and opengraph-collection.cy.ts. Together, these files comprised an extensive suite of tests, examining processes ranging from language switching and media rendering to ensuring the functionality of Twitter links, checking Identity stats, and the creation of collections.

The deletion of these files will heavily affect future testing, potentially leaving aspects of the system unchecked. Changes to the codebase may need to be made to ensure these aspects of the system are appropriately tested moving forward.

@yangwao yangwao merged commit 6ecc459 into main Nov 27, 2023
16 of 17 checks passed
@yangwao yangwao deleted the test/removecypress branch November 27, 2023 18:33
This was referenced Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
large Pull request is large waiting-for-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants