feat: enable ssr on /privacy-policy
#9155
Conversation
refactor: rename plugin files to indicate client-side usage feat: add new posts to posts.json fix: adjust localStorage usage in identity store fix: adjust window object usage in chain and ipfs config fix: adjust extension usage for client-side process
…and '@polkadot/x-global' to transpile list and update '@polkadot/x-global' version to 12.6.2
… vue components fix(package.json): downgrade eslint-plugin-unicorn, eslint-plugin-vue, glob, husky, jsdom, lint-staged versions chore(package.json): remove unused @types/jest and @polkadot/x-global dependencies
refactor(default.vue): remove ClientOnly wrapper from Navbar, Footer, CookieBanner, and Buy components feat(privacy-policy.vue): set page layout to default-ssr
…mport '@google/model-viewer' on client side
fix(nuxt.config.ts): disable sourcemap in vite build configuration
feat: enable ssr on `/privacy-policy`
✅ Deploy Preview for koda-canary ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@braintree/sanitize-url@6.0.4, npm/@nuxtjs/color-mode@3.3.2, npm/@polkadot/api-base@10.12.2, npm/@polkadot/api@10.12.2, npm/@polkadot/types@10.12.2, npm/@types/jest@27.5.2, npm/@types/node@20.11.28, npm/@vitest/coverage-istanbul@0.34.6 |
|
AI-Generated Summary: This pull request includes significant changes in multiple files influencing client-side limiting checks, server-side rendering, updates to JSON data, development and build configurations, and a few changes in typescript configurations.
In sum, this update has a widespread impact on the application, concerning client and server-side operation, development environment configurations, data updates, and library dependency versions. |
|
The build failed again after sync from the main branch. It seems unstable. Let's keep it for several weeks to test it. At the moment, I will change it into a draft PR |
|
After I removed the |
prury
removed
the
S-works-for-me-✅
|
fiuuh, finally, merged |
|
So it's worth pursuing SSR as apparently doesn't add that much score on pagespeed? Does it improve any of following? |
preschian
added
the
S-stale
IMO yes. We can forget about this unless we care about the score. It can help improve the score, especially LCP. Fyi: https://web.dev/articles/optimize-lcp#server-side-rendering. Based on the report from our Cloudflare pages, we have good scores on CLS and FID but not on LCP. SSR is the first step to optimising LCP. If we still need to reach good scores, we must check other metrics, such as javascript size on the client side. But at least we need to land SSR first. 
|
![codeclimate[bot]](https://avatars.githubusercontent.com/in/9403?s=60&v=4){kind=small}
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
|
Code Climate has analyzed commit 270c5b5 and detected 0 issues on this pull request. View more on Code Climate. |
|
|
will revisit the PR later |
Thank you for your contribution to the KodaDot - One Stop Shop for Polkadot NFTs.
👇 __ Let's make a quick check before the contribution.
PR Type
Context
/privacy-policy. To add more pages, add them on theserver/middleware/disable-ssr.tsfile.Improved page speed scores on
/privacy-policy. But not so much, it still has areas of improvement. (some components such asNavbarstill client side)Next steps:
I will fix ci for libs/ui in a separate PR.Turns out not related to this PR, issue herelibs/ui@google/model-viewer build error #9174default-ssrlayout. To test the SSR page. At the moment, some components still do not work on SSR. such as components under<ClientOnly>on thedefault-ssrlayoutDid your issue had any of the "$" label on it?