Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal width to tailwind #9906

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Modal width to tailwind #9906

merged 5 commits into from
Mar 29, 2024

Conversation

iMac7
Copy link
Contributor

@iMac7 iMac7 commented Mar 28, 2024

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix
  • Feature
  • Refactoring

Context

Before submitting pull request, please make sure:

  • My contribution builds clean without any errors or warnings
  • I've merged recent default branch -- main and I've no conflicts
  • I've tried to respect high code quality standards
  • I've didn't break any original functionality

Optional

  • I've tested it at </ahp/collection>
  • I've tested PR on mobile
  • I've written unit tests 🧪
  • I've found edge cases

Did your issue had any of the "$" label on it?

  • Fill up your DOT address: Payout

Community participation

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

@iMac7 iMac7 requested a review from a team as a code owner March 28, 2024 10:16
@iMac7 iMac7 requested review from preschian and Jarsen136 and removed request for a team March 28, 2024 10:16
@kodabot
Copy link
Collaborator

kodabot commented Mar 28, 2024

WARNING @iMac7 PR for issue #9242 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #9242

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit d47271c
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6605438964a8d9000809c8a6
😎 Deploy Preview https://deploy-preview-9906--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 0661fa7
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6606b8c2d4a3620007bc4704
😎 Deploy Preview https://deploy-preview-9906--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@iMac7 iMac7 marked this pull request as draft March 28, 2024 10:44
@iMac7 iMac7 marked this pull request as ready for review March 28, 2024 11:32
@iMac7
Copy link
Contributor Author

iMac7 commented Mar 28, 2024

Screenshot_20240328_143218

@prury maybe this is causing the test to fail?

@iMac7
Copy link
Contributor Author

iMac7 commented Mar 28, 2024

@prury maybe this is causing the test to fail?

yup. strong tests @prury 🔥

@prury
Copy link
Member

prury commented Mar 28, 2024

smoothest tailwind transition I've ever seen? congrats!

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Mar 28, 2024
Copy link

codeclimate bot commented Mar 29, 2024

Code Climate has analyzed commit 0661fa7 and detected 0 issues on this pull request.

View more on Code Climate.

Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@yangwao
Copy link
Member

yangwao commented Mar 29, 2024

Thanks!
pay 30 usd

@yangwao yangwao merged commit 7c8c26c into kodadot:main Mar 29, 2024
18 of 19 checks passed
@yangwao
Copy link
Member

yangwao commented Mar 29, 2024

😍 Perfect, I’ve sent the payout
💵 $30 @ 9.59 USD/DOT ~ 3.128 $DOT
🧗 14dLrAvjDw7cFLaxM7VWR6YtHd7bGZY2QpzXDhAJJ4yv6oGw
🔗 0x70b4876f8fc90ab921c23c59b16a95dcff826e800d041cf5b9607c7aa8a27bf1

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Mar 29, 2024
This was referenced Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
paid pull-request has been paid S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modal-width class to tailwind
6 participants