Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Mobile menu gone on 640-1024px #9916

Merged
merged 6 commits into from
Mar 29, 2024
Merged

fix: Mobile menu gone on 640-1024px #9916

merged 6 commits into from
Mar 29, 2024

Conversation

Jarsen136
Copy link
Contributor

Thank you for your contribution to the Koda - Generative Art Marketplace.

👇 __ Let's make a quick check before the contribution.

PR Type

  • Bugfix

Needs Design check

Context

Did your issue had any of the "$" label on it?

Screenshot 📸

  • My fix has changed something on UI; a screenshot is best to understand changes for others.

image

@Jarsen136 Jarsen136 requested a review from a team as a code owner March 28, 2024 14:04
@Jarsen136 Jarsen136 requested review from preschian and removed request for a team March 28, 2024 14:04
@kodabot
Copy link
Collaborator

kodabot commented Mar 28, 2024

WARNING @Jarsen136 PR for issue #9915 which isn't assigned to you. Please be warned that this PR may get rejected if there's another assignee for issue #9915

@netlify Netlify
Copy link

netlify bot commented Mar 28, 2024 •
edited
Loading

✅ Deploy Preview for koda-canary ready!

Name Link
🔨 Latest commit 4fbe832
🔍 Latest deploy log https://app.netlify.com/sites/koda-canary/deploys/6605b3ac63a8cc000848949f
😎 Deploy Preview https://deploy-preview-9916--koda-canary.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@exezbcz
Copy link
Member

exezbcz commented Mar 28, 2024

lol that was fast

@prury prury requested a review from daiagi March 28, 2024 14:56
@prury
Copy link
Member

prury commented Mar 28, 2024

it appears now but its position its not covering the whole screen:

mobile.burguer.mp4

@prury prury added the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Mar 28, 2024
@Jarsen136
Copy link
Contributor Author

it appears now but its position its not covering the whole screen:

✅ Fixed. It's from canary env though.

@daiagi
Copy link
Contributor

daiagi commented Mar 28, 2024

the width of the navbar change when opening/closing the burger menu

@prury
Copy link
Member

prury commented Mar 28, 2024

it appears now but its position its not covering the whole screen:

✅ Fixed. It's from canary env though.

thank you for going beyond then

@codeclimate CodeClimate
Copy link

codeclimate bot commented Mar 28, 2024

Code Climate has analyzed commit 4fbe832 and detected 0 issues on this pull request.

View more on Code Climate.

@Jarsen136
Copy link
Contributor Author

the width of the navbar change when opening/closing the burger menu

✅ Fixed too

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.3% Duplication on New Code

See analysis details on SonarCloud

@daiagi daiagi added the S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved label Mar 29, 2024
@prury prury removed the S-changes-requested-🤞 PR is almost good to go, just some fine tunning label Mar 29, 2024
@prury
Copy link
Member

prury commented Mar 29, 2024 •
edited
Loading

@Jarsen136 created another issue, lmk if you want to solve it here or on another PR

@prury prury added the S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked label Mar 29, 2024
@Jarsen136
Copy link
Contributor Author

@Jarsen136 created another issue, lmk if you want to solve it here or on another PR

I would make it on another PR

@prury prury added this pull request to the merge queue Mar 29, 2024
@prury
Copy link
Member

prury commented Mar 29, 2024

@yangwao payment

Merged via the queue into kodadot:main with commit bd75586 Mar 29, 2024
19 checks passed
@prury
Copy link
Member

prury commented Apr 3, 2024

pay 15 usd

@yangwao
Copy link
Member

yangwao commented Apr 3, 2024

😍 Perfect, I’ve sent the payout
💵 $15 @ 8.45 USD/DOT ~ 1.775 $DOT
🧗 16SjUbGKSdjCdWTy3NNT3JxbRVGGqD4mwkHpc6BD9U2Rp29Z
🔗 0xf8b4832e5cbddf7518b03c1a3a10d42220ef72fad7884ea317b0c3d6b5a681d7

🪅 Let’s grab another issue and get rewarded!
🪄 github.com/kodadot/nft-gallery/issues

@yangwao yangwao added the paid pull-request has been paid label Apr 3, 2024
This was referenced Apr 4, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@preschian preschian preschian approved these changes

@daiagi daiagi daiagi approved these changes

Assignees
No one assigned
Labels
paid pull-request has been paid S-code-lgtm-✅ code review guild has reviewed this PR and it's code is approved S-works-for-me-✅ qa-guild has tested PR from end user perspective and functionality worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mobile menu gone on 640-1024px
7 participants
@Jarsen136 @kodabot @exezbcz @prury @daiagi @yangwao @preschian