Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade minimark deps #215

Merged
merged 2 commits into from
Feb 25, 2025
Merged

chore: upgrade minimark deps #215

merged 2 commits into from
Feb 25, 2025

Conversation

preschian
Copy link
Member

@preschian preschian commented Feb 25, 2025

Context

Screenshot 2025-02-25 at 19 08 42

PR Type

  • Bugfix
  • Feature
  • Refactoring
  • Chore

@preschian preschian requested a review from vikiival February 25, 2025 12:10
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Obfuscated code npm/@polkadot/util-crypto@13.4.3 ⚠︎

View full report↗︎

Next steps

What is obfuscated code?

Obfuscated files are intentionally packed to hide their behavior. This could be a sign of malware.

Packages should not obfuscate their code. Consider not using packages with obfuscated code.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/foo@1.0.0 or ignore all packages with @SocketSecurity ignore-all

  • @SocketSecurity ignore npm/@polkadot/util-crypto@13.4.3

@vikiival
Copy link
Member

@preschian minimark should be removed from nft-gallery

@vikiival vikiival merged commit 3415c82 into main Feb 25, 2025
3 checks passed
@preschian preschian deleted the chore--upgrade-minimark-deps branch February 26, 2025 03:54
@preschian
Copy link
Member Author

@preschian minimark should be removed from nft-gallery

noted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants